Review main Abandoned

92267[WIP][TASK] Mark LanguageAll record handling

Eric Harrer CR 0 V 0 Normal +59 −0 updated 10/07/26, 14:19

Commit message

Add TODO markers for code paths that depend on the persisted
LanguageAll value (-1) in record language fields.

Limit the annotations to places that read, write, filter, or interpret
record language values and therefore need review before replacing
persisted -1 values with a dedicated all-languages flag.

Related assertions and fixtures are annotated where they document the
same assumptions.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 39

Show 19 more files

Review log 1218

  1. Eric Harrer uploaded patch set 1 01/09/26, 11:30

  2. core-ci voted on patch set 1 V +1 01/09/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93145

  3. Eric Harrer uploaded patch set 2 V +1 01/12/26, 11:29

  4. core-ci voted on patch set 2 V +1 01/12/26, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93268

  5. Eric Harrer uploaded patch set 3 V +1 01/13/26, 22:33

  6. core-ci voted on patch set 3 V +1 01/13/26, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93407

  7. Benni Mack commented on patch set 3 02/02/26, 12:47

    how about we use a class constant somehow for the ones with "-1"?
  8. Benni Mack wrote 04/21/26, 14:49

    Removed cc Benni Mack.
  9. Benni Mack marked it work in progress 04/21/26, 14:49

  10. Eric Harrer uploaded patch set 4 V +1 04/24/26, 12:36

  11. core-ci voted on patch set 4 V +1 04/24/26, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101084

  12. Benni Mack uploaded patch set 5 V +1 08/07/26, 13:38

  13. core-ci voted on patch set 5 V +1 08/07/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106119

  14. Benni Mack rebased onto patch set 6 V +1 08/07/26, 15:14

  15. core-ci voted on patch set 6 V +1 08/07/26, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106131

  16. Benni Mack commented on patch set 6 08/10/26, 13:15

    quick idea (on top of the comments). Lets add 2 constants (or an Enum) reflecting "0" and "-1" (after a quick talk with @andy.schliesser@gmail.com ) and replace all places as well in Core, so we know the dependencies and places directly. Also: Please use "@todo" instead of "TODO"
  17. Benni Mack commented on patch set 6 09/03/26, 21:20

    Unresolved

    here is this one https://review.typo3.org/c/Packages/TYPO3.CMS/+/95619 - please check if I forgot things
  18. Benni Mack abandoned the change 10/07/26, 14:19

    I will abandon this one now