Review main Merged

92271[TASK] Refactor editconf to use individual UIDs instead of CSV

Benni Mack CR +2 V +2 Hard +143 −158 updated 01/14/26, 20:05

Commit message

EditDocumentController previously supported storing multiple UIDs
as comma-separated strings in array keys within the editconf property
(e.g., "1,2,3" => "edit"). This required repeated parsing and splitting
throughout the codebase.

This patch refactors editconf to store UIDs as individual array keys
instead (e.g., 1 => "edit", 2 => "edit", 3 => "edit"), which
eliminates repeated string splitting and reduces complexity in
makeEditForm() and related methods.

The sanitizeEditConf() method now handles the conversion during
initialization, splitting any comma-separated UID lists into
individual array entries and applying workspace versioning logic
at the end of sanitization.

Existing URIs with the comma-separated lists continue to work,
(e.g. `/typo3/record/edit?token=abc&edit[sys_category][47,11]=edit`).

Drive-by fix: The "Edit all columns" button is now only shown
when columnsOnly is used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Benni Mack uploaded patch set 1 01/09/26, 21:01

  2. core-ci voted on patch set 1 V +1 01/09/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93167

  3. Benni Mack uploaded patch set 2 V +1 01/14/26, 17:40

  4. core-ci voted on patch set 2 V +1 01/14/26, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93468

  5. Garvin Hicking uploaded patch set 3 V +1 01/14/26, 18:52

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 01/14/26, 18:52

  7. core-ci voted on patch set 3 V +1 01/14/26, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93471

  8. Jochen Roth voted on patch set 3 CR +1 V +1 01/14/26, 19:24

  9. Benni Mack voted on patch set 3 CR +2 V +2 01/14/26, 20:04

  10. Benni Mack merged patch set 4 01/14/26, 20:05