Review 13.4 Merged

92273[BUGFIX] Avoid using null as array key in DatabaseRecordList

Georg Ringer CR +2 V +2 Easy +7 −7 updated 01/12/26, 08:42

Commit message

Using `NULL` as array key is converted to an empty
string in PHP and is deprecated since PHP8.5.0,
honored with following `E_DEPRECATED` error:

  Using null as an array offset is deprecated,
  use an empty string instead

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Georg Ringer uploaded patch set 1 01/10/26, 08:42

  2. Georg Ringer commented on patch set 1 01/10/26, 08:42

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/10/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93191

  4. Oliver Klee commented on patch set 1 01/10/26, 12:15

    Just to be sure: main is not affected? (Haven't checked, and there's no information on that front in the ticket.)
  5. Georg Ringer commented on patch set 1 01/10/26, 12:25

    Reply

    main is not affected using tcaschema api
  6. Oliver Klee voted on patch set 1 CR +1 01/10/26, 12:41

  7. Stefan Bürk voted on patch set 1 CR +1 V +1 01/10/26, 22:51

  8. Oliver Klee voted on patch set 1 V +1 01/11/26, 11:56

  9. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/11/26, 14:57

  10. Stefan Bürk voted on patch set 1 CR +2 V +2 01/12/26, 08:42

  11. Stefan Bürk merged patch set 2 01/12/26, 08:42