Review main Abandoned

92274[BUGFIX] Add explicit string cast in FlexFormTools

David Zach CR 0 V -1 Easy +1 −1 updated 01/10/26, 23:07

Commit message

Add explicit type cast to string for record type field value to ensure consistent string handling and prevent potential type-related issues when the field value is null or of unexpected type.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 34

  1. David Zach uploaded patch set 1 01/10/26, 08:49

  2. core-ci voted on patch set 1 V -1 01/10/26, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93193

  3. Oliver Klee commented on patch set 1 01/10/26, 12:06

    FlexFormTools.php:737 Unresolved

    You'll need to use parentheses here as otherwise the string cast will happen before the null coalescing: ```suggestion $recordType = (string) ($row[$schema->getSubSchemaTypeInformation()->getFieldName()] ?? ''); ```
  4. Stefan Bürk abandoned the change 01/10/26, 23:07

    Abanding this change in favour of 92275: [TASK] Fix PHPStan error in FlexFormTools | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92275 as it seems that this was a first change and continued with the new change, missing correct amend of changes.