Review main Merged

92275[BUGFIX] Add explicit string cast in FlexFormTools

David Zach CR +2 V +2 Easy +2 −2 updated 01/12/26, 21:12

Commit message

Add explicit type cast to string for record type field value to ensure consistent string handling and prevent potential type-related issues when the field value is null or of unexpected type.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. David Zach uploaded patch set 1 01/10/26, 09:03

  2. core-ci voted on patch set 1 V +1 01/10/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93194

  3. Oliver Klee voted on patch set 1 CR +1 01/10/26, 12:05

  4. Georg Ringer uploaded patch set 2 CR +1 V +1 01/10/26, 12:06

  5. core-ci voted on patch set 2 V +1 01/10/26, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93202

  6. Oliver Klee voted on patch set 2 CR +1 01/10/26, 12:16

  7. Georg Ringer voted on patch set 2 CR +1 V +1 01/10/26, 12:25

  8. Stefan Bürk commented on patch set 2 CR -1 01/10/26, 22:59

    I really question the commit message. The made statements in it does not match the change in any way - or explain it really badly.
    > Move string cast outside of null coalescing operator to fix This change does not move a string cast - it introcudes one and nesting the original code part with the null coalsce fallback handling.
    > fix PHPStan error "Expression on left side of ?? is not nullable". I really don't get this. IF this change really fixes a phpstan error, where is the update of the baseline as it should have been added to it before. There is no change, so I really question the correctnes of the commit message and the made statements here.
  9. Stefan Bürk commented on patch set 2 01/10/26, 23:02

    FlexFormTools.php:738

    ```suggestion if ($recordType !== '' && $schema->hasSubSchema($recordType) && ($subSchema = $schema->getSubSchema($recordType))->hasField($fieldName)) { ``` I guess we should add a check for empty string here, `"0"` still valid and the reason a `empty()` is not suitable.
  10. Stefan Bürk commented on patch set 2 01/10/26, 23:06

    ```suggestion [BUGFIX] Avoid method argument type error in FlexFormTools ```

    Reply

    I guess the phrasing comes from having it on top of 92274: [BUGFIX] Add explicit string cast in FlexFormTools | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92274 which added teh string cast but without the nesting.
  11. David Zach updated the commit message in patch set 3 CR +1 V +1 01/11/26, 07:34

  12. core-ci voted on patch set 3 V +1 01/11/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93233

  13. Stefan Bürk commented on patch set 3 01/12/26, 01:00

    Reply

    Done
  14. Stefan Bürk commented on patch set 3 01/12/26, 01:00

    Reply

    Done

    Reply

    Done

    Reply

    Done
  15. David Zach commented on patch set 4 V +1 01/12/26, 05:32

    Published edit on patch set 3.
  16. core-ci voted on patch set 4 V +1 01/12/26, 05:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93262

  17. Oliver Klee voted on patch set 4 CR +1 01/12/26, 08:31

  18. Oli Bartsch commented on patch set 4 CR +1 V +1 01/12/26, 16:46

    FlexFormTools.php:738 Reply

    Done
  19. Stefan Bürk voted on patch set 4 CR +2 V +2 01/12/26, 21:12

  20. Stefan Bürk merged patch set 5 01/12/26, 21:12