92318[FEATURE] Centralize Bookmark Management
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 74
- Build/phpstan/phpstan-baseline.neon+0 −6
- Build/Sources/Sass/component/_bookmark-manager.scssnew+84 −0
- Build/Sources/Sass/component/_form.scss+11 −0
- Build/Sources/Sass/component/_table.scss+18 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/bookmark/element/bookmark-button-element.tsnew+144 −0
- Build/Sources/TypeScript/backend/bookmark/toolbar/bookmark-menu-element.tsnew+139 −0
- Build/Sources/TypeScript/backend/bookmark/bookmark-manager.tsnew+1234 −0
- Build/Sources/TypeScript/backend/bookmark/bookmark-store.ts5new+700 −0
- Build/Sources/TypeScript/backend/toolbar/shortcut-menu.tsdeleted+0 −254
- Build/Sources/TypeScript/backend/action-dispatcher.ts+0 −2
- Build/Sources/TypeScript/backend/modal.ts+4 −0
- Build/Sources/TypeScript/dashboard/widget/bookmarks-widget-element.tsnew+140 −0
- Build/tests/playwright/e2e/toolbar/bookmark.spec.tsnew+106 −0
- Build/types/TYPO3/index.d.ts+1 −1
- typo3/sysext/backend/Classes/Backend/Bookmark/Security/BookmarkGroupVoter.phpnew+93 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/Security/BookmarkVoter.php6new+253 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/Traits/RouteParserTrait.php4new+67 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/Bookmark.phpnew+65 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkGroup.phpnew+55 −0
Show 54 more files
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkGroupType.phpnew+57 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkRepository.php2new+432 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkService.php38new+622 −0
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.phpdeleted+0 −611
- typo3/sysext/backend/Classes/Backend/ToolbarItems/BookmarkToolbarItem.phprenamed+10 −26
- typo3/sysext/backend/Classes/Controller/BackendController.php+10 −0
- typo3/sysext/backend/Classes/Controller/BookmarkController.php10new+319 −0
- typo3/sysext/backend/Classes/Controller/ShortcutController.phpdeleted+0 −129
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php2+37 −54
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownGeneric.php4new+42 −0
- typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php+6 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+52 −23
- typo3/sysext/backend/Configuration/user.tsconfig+9 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_toolbar.xlf+0 −42
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/BookmarkToolbarItemDropDown.fluid.htmlnew+1 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/BookmarkToolbarItemItem.fluid.htmlnew+9 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemDropDown.fluid.htmldeleted+0 −61
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemEditForm.fluid.htmldeleted+0 −26
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemItem.fluid.htmldeleted+0 −21
- typo3/sysext/backend/Resources/Public/Css/backend.css+14 −0
- typo3/sysext/backend/Resources/Public/JavaScript/bookmark/element/bookmark-button-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/bookmark/toolbar/bookmark-menu-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/bookmark/bookmark-manager.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/bookmark/bookmark-store.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/shortcut-menu.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/action-dispatcher.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/backend/Tests/Functional/Backend/Bookmark/BookmarkServiceTest.phprenamed+47 −65
- typo3/sysext/backend/Tests/Functional/Backend/Fixtures/BookmarksAddedResult.csvrenamed+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Fixtures/BookmarkControllerTest.csvnew+23 −0
- typo3/sysext/backend/Tests/Functional/Controller/BookmarkControllerTest.phpnew+507 −0
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.phpdeleted+0 −97
- typo3/sysext/backend/Tests/Functional/Controller/SubmoduleOverviewControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.php+1 −16
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.php+1 −15
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.php+1 −14
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.php+3 −24
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.php+1 −16
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.php+1 −16
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.php+3 −25
- typo3/sysext/backend/Tests/Unit/Backend/Bookmark/Security/BookmarkGroupVoterTest.php2new+350 −0
- typo3/sysext/backend/Tests/Unit/Backend/Bookmark/Security/BookmarkVoterTest.php4new+408 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108796-CentralizeBookmarkManagement.rst8new+93 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Important-108796-InternalShortcutClassesRenamedToBookmark.rstnew+36 −0
- typo3/sysext/core/Resources/Private/Language/locallang_bookmarks.xlf4new+294 −0
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+0 −24
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.phpdeleted+0 −127
- typo3/sysext/core/ext_tables.sql4+13 −0
- typo3/sysext/dashboard/Classes/Widgets/BookmarksWidget.php2+52 −70
- typo3/sysext/dashboard/Configuration/Services.yaml+2 −2
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+0 −30
- typo3/sysext/dashboard/Resources/Private/Language/locallang_widget_bookmarks.xlf6new+32 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/BookmarksWidget.fluid.html+9 −47
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget/bookmarks-widget-element.jsnew+13 −0
Review log 67101
Show 4976 earlier messages
-
Benjamin Kott uploaded patch set 1 01/13/26, 18:31
-
Benjamin Kott marked it work in progress 01/13/26, 18:31
-
core-ci voted on patch set 1 V -1 01/13/26, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93394
-
Benjamin Kott uploaded patch set 2
V -101/13/26, 18:45 -
Benjamin Kott uploaded patch set 3 01/13/26, 18:56
-
core-ci voted on patch set 2 V -1 01/13/26, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93396
-
Benjamin Kott rebased onto patch set 4 01/13/26, 19:08
-
core-ci voted on patch set 3 V -1 01/13/26, 19:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93398
-
core-ci voted on patch set 4 V -1 01/13/26, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93400
-
Benjamin Kott uploaded patch set 5
V -101/20/26, 09:15 -
core-ci voted on patch set 5 V -1 01/20/26, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93851
-
Benjamin Kott uploaded patch set 6
V -101/20/26, 16:00 -
core-ci voted on patch set 6 V -1 01/20/26, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93875
-
Benjamin Kott uploaded patch set 7
V -101/24/26, 01:04 -
core-ci voted on patch set 7 V -1 01/24/26, 01:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94219
-
Benjamin Kott marked it ready for review 01/24/26, 18:11
-
Simon Praetorius commented on patch set 7 01/25/26, 17:17
FYI Fluid templates need to be renamed to .fluid.html here. -
Benjamin Kott commented on patch set 7 01/26/26, 07:44
Reply
👍 -
Benjamin Kott uploaded patch set 8
V -101/26/26, 08:48 -
core-ci voted on patch set 8 V -1 01/26/26, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94347
-
Benjamin Kott uploaded patch set 9
V -101/26/26, 09:07 -
core-ci voted on patch set 9 V -1 01/26/26, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94348
-
Benjamin Kott uploaded patch set 10
V -101/26/26, 11:30 -
core-ci voted on patch set 10 V -1 01/26/26, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94354
-
Benjamin Kott uploaded patch set 11
V -101/27/26, 14:48 -
core-ci voted on patch set 11 V -1 01/27/26, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94429
-
Benjamin Kott uploaded patch set 12
V -101/27/26, 16:55 -
core-ci voted on patch set 12 V -1 01/27/26, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94441
-
Benjamin Kott uploaded patch set 13
V -101/28/26, 07:50 -
core-ci voted on patch set 13 V -1 01/28/26, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94480
-
Benjamin Kott uploaded patch set 14
V -101/28/26, 13:30 -
core-ci voted on patch set 14 V -1 01/28/26, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94500
-
Benjamin Kott uploaded patch set 15
V -101/28/26, 15:26 -
core-ci voted on patch set 15 V -1 01/28/26, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94511
-
Benjamin Kott uploaded patch set 16
V -101/28/26, 15:56 -
core-ci voted on patch set 16 V -1 01/28/26, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94513
-
Benjamin Kott uploaded patch set 17
V -101/28/26, 16:19 -
Benjamin Kott uploaded patch set 18 01/28/26, 16:21
-
Benjamin Kott uploaded patch set 19 01/28/26, 16:24
-
core-ci voted on patch set 17 V +1 01/28/26, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94514
-
core-ci voted on patch set 18 V +1 01/28/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94515
-
core-ci voted on patch set 19 V +1 01/28/26, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94516
-
Andreas Kienast commented on patch set 19 01/28/26, 16:51
bookmark-store.ts:141This method is unusedbookmark-store.ts:148Why do we return a plain array here?ext_tables.sql:76Why do we use UUIDs over `int` ids? If we really *have to* use UUIDs, we should consider using `CHAR(36)` instead. -
Benjamin Kott uploaded patch set 20
V +101/28/26, 16:55 -
core-ci voted on patch set 20 V +1 01/28/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94519
-
Benjamin Kott uploaded patch set 21
V +101/28/26, 17:18 -
Benjamin Kott commented on patch set 20 01/28/26, 17:18
bookmark-store.ts:141ReplyDone -
Benjamin Kott commented on patch set 21 01/28/26, 17:20
ext_tables.sql:76Replyit was easier to differentiate between the numeric group id´s from tsconfig -
core-ci voted on patch set 21 V +1 01/28/26, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94524
-
Garvin Hicking commented on patch set 21 01/28/26, 19:40
BookmarkGroupVoterTest.php:36(Also move to bottom)BookmarkVoterTest.php:44please move private helper methods to the bottom of the tests so the actual tests can be seen earlierBookmarkVoterTest.php:99why not use the createBqckendUser helper here too? Could react on the uid set to null maybeFeature-108796-CentralizeBookmarkManagement.rst:40```suggestion .. code-block:: typoscript .. :caption: EXT:my_ext/Configuration/TSConfig/page.typoscript ``` something like that. I don't know where to locate this actually, mobile review only ^^Feature-108796-CentralizeBookmarkManagement.rst:43Should we use speaking group identifiers? That would probably prevent to rename/remove a wrong group accidentally. We could maybe even prefix core groups like "core_files", "core_records" etc, and establish that prefix ? (If that is due to "legacy" maybe now would be the time to introduce a new/different key and deprecate the old?)Feature-108796-CentralizeBookmarkManagement.rst:59```suggestion :typoscript:`extension_key.domain:translation_key`, which resolves to the default ``` The domain or "messages" fallback is missingFeature-108796-CentralizeBookmarkManagement.rst:70```suggestion A new modal-based :guilabel:`Bookmark Manager` provides a centralized interface for ``` -
Garvin Hicking commented on patch set 21 01/28/26, 21:15
BookmarkRepository.php:61Strict array check here ro avoid empty()BookmarkService.php:180Not a dto/vo here, no named arguments (also above)BookmarkService.php:198Maybe accessing the repository to instantiate a single result row is a bit more lightweight? (Then again, users will probably have hundreds of bookmarks...)BookmarkService.php:265No named arguments hereBookmarkService.php:394No named argumentsBookmarkService.php:488Do you intend this class to be extended? Otherwise we should do final + private hereBookmarkService.php:520Avoid "empty" here and do strict checksBookmarkService.php:590could also be a factory / createFrom method withith the BookmarkGrouo voBookmarkVoter.php:184I think this can be injectedBookmarkVoter.php:217Use bookmark terminology hereRouteParserTrait.php:26This feels like it should not be in the bookmark scope only? How about an injectable service class instead, and lart of the router scope instead of bookmark? (personally I'm not too fond of traits)BookmarkController.php:52I think to keep things leaner all the method comments can go, they're rather redundant given the method name and AJAX scope of the whole controller.BookmarkController.php:253Obvious comment is obviousShortcutButton.php:193Adapt variables to "bookmark" terminology (Class can't be renamed, I know)DropDownGeneric.php:25This is more of a VeryGenericWebComponent() instead of limited to a Dropdown, maybe rename it?locallang_bookmarks.xlf:82```suggestion <source>The bookmark could not be created</source> ```locallang_bookmarks.xlf:91```suggestion <source>The bookmark could not be deleted.</source> ```BookmarksWidget.php:53Can we use the donainnsyntax here yet?locallang_widget_bookmarks.xlf:22```suggestion <source>Defines how many bookmark items should be shown.</source> ```locallang_widget_bookmarks.xlf:25```suggestion <source>Show all bookmarks</source> ```locallang_widget_bookmarks.xlf:28```suggestion <source>Manage bookmarks</source> ``` -
Benjamin Kott uploaded patch set 22
V +101/29/26, 10:02 -
Benjamin Kott commented on patch set 22 01/29/26, 10:02
bookmark-store.ts:148ReplyWe are creating a shallow copy here, and do not pass a reference to avoid that the state of the store is changed.BookmarkRepository.php:61ReplyDoneBookmarkService.php:180ReplyDoneBookmarkService.php:198ReplyDoneBookmarkService.php:265ReplyDoneBookmarkService.php:394ReplyDoneBookmarkService.php:488Replymade them privateBookmarkService.php:520ReplyDoneBookmarkService.php:590Replywe need access to the voter that also may need the router so we should not move it to the dto, i tried to keep it small here - no hard opinion here, we would need a factory then.BookmarkVoter.php:184ReplyDoneBookmarkVoter.php:217ReplyDoneRouteParserTrait.php:26Replyneeded this in multiple places, not a big fan, but a trait felt like the best option in that caseBookmarkController.php:52ReplyDoneShortcutButton.php:193ReplyDoneDropDownGeneric.php:25Replynot sure, it's like really generic and only disables the hard label checksBookmarkGroupVoterTest.php:36ReplyDoneBookmarkVoterTest.php:44ReplyDoneFeature-108796-CentralizeBookmarkManagement.rst:40ReplyDoneFeature-108796-CentralizeBookmarkManagement.rst:43Replyi decided to document the current behavior here again to also add remarks about limitations, we would need more changes to achieve that, that also would include database changes and internal handling - i marked this out of scope for now as it would only provide a limited benefit.Feature-108796-CentralizeBookmarkManagement.rst:59ReplyDoneFeature-108796-CentralizeBookmarkManagement.rst:70ReplyDonelocallang_bookmarks.xlf:82ReplyDonelocallang_bookmarks.xlf:91ReplyDoneBookmarksWidget.php:53ReplyDonelocallang_widget_bookmarks.xlf:22ReplyDonelocallang_widget_bookmarks.xlf:25ReplyDonelocallang_widget_bookmarks.xlf:28ReplyDone -
Benjamin Kott commented on patch set 22 01/29/26, 10:03
BookmarkController.php:253ReplyDone -
Benjamin Kott uploaded patch set 23 01/29/26, 10:12
-
Benjamin Kott commented on patch set 23 01/29/26, 10:12
BookmarkVoterTest.php:99ReplyDone -
core-ci voted on patch set 22 V -1 01/29/26, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94560
-
core-ci voted on patch set 23 V -1 01/29/26, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94562
-
Benjamin Kott uploaded patch set 24
V -101/29/26, 11:05 -
Benjamin Franzke commented on patch set 24 01/29/26, 11:14
RouteParserTrait.php:26Replyas this code is basically an extract of the previous shortcut handler, it is fine for me to be in this scope, especially since it is not 100% right: `record_edit` and `file_edit` are not module names, but are handled the same here for the sake of convenience, to make them "allowed" shortcut targets. I'd leave it in the Bookmark/ namespace for now. -
core-ci voted on patch set 24 V +1 01/29/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94563
-
Garvin Hicking commented on patch set 24 01/29/26, 12:09
DropDownGeneric.php:25ReplyHow about "UnlabelledComponent" then? -
Garvin Hicking commented on patch set 24 01/29/26, 12:10
BookmarkService.php:590ReplyI don't mind too much about this and can also be part of later cleanup, being private and internal for now.RouteParserTrait.php:26ReplyAcknowledged -
Georg Ringer commented on patch set 24 CR +1 V +1 01/29/26, 13:42
only issue I found was that it seems that html is removed from group/bookmark titles, IMHO we shouldn't modify the data a user adds - outputting is done correctly, so no xss here -
Benjamin Kott uploaded patch set 25
CR +1V +101/29/26, 14:19 -
Benjamin Kott commented on patch set 25 01/29/26, 14:21
@georg.ringer@gmail.com checked with @ben@bnf.dev - the strip tags were here before, but we only have safe renderings now so we can remove it. -
core-ci voted on patch set 25 V -1 01/29/26, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94585
-
Benjamin Kott uploaded patch set 26
V -101/29/26, 14:32 -
core-ci voted on patch set 26 V +1 01/29/26, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94586
-
Garvin Hicking commented on patch set 26 V +1 01/29/26, 17:58
Did a lot of rounds on actually using the UI now and I couldn't break it, seems to work all quite well! Thanks!BookmarkService.php:146```suggestion if ($groupId <= 0 || $groupId === 100 || $configLabel === null || $configLabel === '') { ```BookmarkService.php:265ReplyIt's still there? Reference: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/PhpArchitecture/NamedArguments.html#typo3-core-development (I won't commit on the other instances where this is contained as well and needs to be changed to keep my comments manageable)BookmarkService.php:354```suggestion if ($manageableIds !== []) { ```BookmarkService.php:389```suggestion if ($manageableIds === []) { ```BookmarkService.php:520```suggestion $groupId = ($row['group_uuid'] !== '' && $row['group_uid'] !== null) ? $row['group_uuid'] : (int)$row['sc_group']; ```BookmarkService.php:521```suggestion $bookmarkData = $this->parseRecordEditData($routeIdentifier, $arguments); ```BookmarkService.php:522```suggestion $iconData = $this->resolveBookmarkIcon($routeIdentifier, $moduleName, $bookmarkData); ```BookmarkService.php:543```suggestion private function resolveBookmarkIcon(string $routeIdentifier, string $moduleName, array $bookmarkData): array ```BookmarkService.php:550```suggestion $table = $bookmarkData['table'] ?? ''; ```BookmarkService.php:551```suggestion $recordid = $bookmarkData['recordid'] ?? 0; ```BookmarkService.php:553```suggestion $action = $bookmarkData['action'] ?? ''; ```BookmarkController.php:151```suggestion if (!is_array($bookmarkIds) || $bookmarkIds === []) { ```BookmarkController.php:193```suggestion if (!is_array($bookmarkIds) ||$bookmarkIds === []) { ```BookmarkController.php:293```suggestion if (!is_array($uuids) || $uuids === []) { ``` -
Anja Leichsenring commented on patch set 26 V +1 01/30/26, 06:07
works nicely, could not manage to trigger any errors. -
Benjamin Kott uploaded patch set 27
V +101/30/26, 07:29 -
Benjamin Kott commented on patch set 27 01/30/26, 07:29
BookmarkService.php:146ReplyDoneBookmarkService.php:265ReplyDoneBookmarkService.php:354ReplyDoneBookmarkService.php:389ReplyDoneBookmarkService.php:520ReplyDoneBookmarkService.php:521ReplyDoneBookmarkService.php:522ReplyDoneBookmarkService.php:543ReplyDoneBookmarkService.php:550ReplyDoneBookmarkService.php:551ReplyDoneBookmarkService.php:553ReplyDoneBookmarkService.php:590ReplyDoneBookmarkController.php:151ReplyDoneBookmarkController.php:193ReplyDoneBookmarkController.php:293ReplyDone -
core-ci voted on patch set 27 V +1 01/30/26, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94627
-
Garvin Hicking commented on patch set 27 CR +1 V +1 01/30/26, 07:39
(Code-Review vote based on PHP-side, can't judge the JS aspect) -
Andreas Kienast commented on patch set 27 01/30/26, 09:53
bookmark-store.ts:148ReplyAcknowledged
-
Benjamin Kott commented on patch set 27 01/30/26, 10:08
DropDownGeneric.php:25Replylet's keep it generic for now -
Benjamin Kott uploaded patch set 28
CR +1V +101/30/26, 11:49 -
Benjamin Kott commented on patch set 28 01/30/26, 11:50
ext_tables.sql:76ReplyDone -
core-ci voted on patch set 28 V -1 01/30/26, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94652
-
Benjamin Kott uploaded patch set 29
V -101/30/26, 12:31 -
Benjamin Franzke commented on patch set 28 01/30/26, 12:33
ext_tables.sql:76Replywell, there is also `uuid`: https://dev.mysql.com/blog-archive/mysql-8-0-uuid-support/ https://www.postgresql.org/docs/current/datatype-uuid.html -
core-ci voted on patch set 29 V -1 01/30/26, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94658
-
Benjamin Franzke uploaded patch set 30
V -101/30/26, 13:43 -
core-ci voted on patch set 30 V +1 01/30/26, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94670
-
Garvin Hicking commented on patch set 30 CR +1 V +1 01/30/26, 14:19
(I tested this with mysql 8.0.40 which uses char(36) as the type. I figure that uuid needs to work generally in the core, otherwise it would be a follow-up bugfix) -
Benjamin Kott uploaded patch set 31 01/30/26, 14:31
Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Benjamin Franzke voted on patch set 31 CR -1 01/30/26, 14:38
-
core-ci voted on patch set 31 V +1 01/30/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94676
-
Benjamin Kott uploaded patch set 32
CR +1V +101/30/26, 15:31 -
core-ci voted on patch set 32 V +1 01/30/26, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94685
-
Garvin Hicking voted on patch set 32 CR +1 V +1 01/30/26, 16:43
-
Benjamin Franzke uploaded patch set 33
CR +1V +101/30/26, 19:37 -
core-ci voted on patch set 33 V +1 01/30/26, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94701
-
Nikita Hovratov commented on patch set 33 01/30/26, 19:51
BookmarkVoter.php:46can this class be readonly? -
Benjamin Franzke uploaded patch set 34
CR +1V +102/02/26, 07:51 -
Benjamin Franzke commented on patch set 34 CR +1 V +1 02/02/26, 07:51
BookmarkVoter.php:46ReplyDone -
core-ci voted on patch set 34 V +1 02/02/26, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94797
-
Garvin Hicking voted on patch set 34 CR +1 V +1 02/02/26, 13:21
-
Benjamin Franzke commented on patch set 34 CR +2 V +2 02/02/26, 15:48
It's a large patchset, but it's hard to split or anything, so I think we should merge now an and fix possible issues afterwards. It waited for a couple of days now. -
Benjamin Franzke merged patch set 35 02/02/26, 15:48