Review main Merged

92321[FEATURE] Allow adding inline language domains to JavaScript

Benjamin Kott CR +2 V +2 Normal +110 −0 updated 01/15/26, 21:15

Commit message

The new method `PageRenderer->addInlineLanguageDomain()` allows loading
all labels from a language domain and making them available in
JavaScript via the TYPO3.lang object.

The domain name follows the format "extension.domain" (e.g.
'core.common', 'core.modules.media').

Labels are automatically prefixed with the domain name and accessible
as TYPO3.lang['domain:key'], e.g. TYPO3.lang['core.common:goTo'].

Previously, loading entire language files via
`addInlineLanguageLabelFile()` added labels without any prefix, which
could lead to naming conflicts when multiple extensions used the same
label keys.

The new domain-based approach provides namespaced access and eliminates
the risk of collisions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Benjamin Kott uploaded patch set 1 01/13/26, 19:07

  2. core-ci voted on patch set 1 V +1 01/13/26, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93399

  3. Garvin Hicking commented on patch set 1 01/14/26, 14:12

    on it
  4. Garvin Hicking uploaded patch set 2 V +1 01/14/26, 14:42

  5. core-ci voted on patch set 2 V +1 01/14/26, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93456

  6. Garvin Hicking commented on patch set 2 01/14/26, 14:51

    Reply

    Done
  7. Garvin Hicking voted on patch set 2 CR +1 V +1 01/14/26, 14:52

  8. Benni Mack commented on patch set 2 CR +2 V +2 01/15/26, 21:15

    we could actually replace all the addInlineLanguageLabelFile calls finally
  9. Benni Mack merged patch set 3 01/15/26, 21:15