Review main Ready for review Orphaned

92326[FEATURE] Introduce dashboard widget for largest unused files

Ulrich Mathes CR 0 V 0 Hard +453 −0 updated 03/18/26, 13:40

Commit message

This patch adds a new widget for EXT:dashboard. The widget fetches a
list of large files (ordered by sys_file.size) which are not referenced
in sys_refindex.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/92326/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/92326/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 7

Review log 1928

Show 23 earlier messages
  1. Ulrich Mathes uploaded patch set 1 01/14/26, 11:29

  2. core-ci voted on patch set 1 V +1 01/14/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93433

  3. Ulrich Mathes uploaded patch set 2 V +1 01/21/26, 15:43

  1. core-ci voted on patch set 2 V +1 01/21/26, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93961

  2. Josua Vogel commented on patch set 2 01/21/26, 15:54

    this should´nt target Releases: main, 12.4 only Releases: main

    Feature-108628-IntroduceDashboardWidgetForLargestUnusedFiles.rst:1

    please put that file into Changelog/14.2
  3. Ulrich Mathes uploaded patch set 3 V +1 01/21/26, 16:01

  4. core-ci voted on patch set 3 V +1 01/21/26, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93964

  5. Ulrich Mathes commented on patch set 3 01/23/26, 11:07

    Reply

    Acknowledged

    Feature-108628-IntroduceDashboardWidgetForLargestUnusedFiles.rst:1 Reply

    Acknowledged
  6. Guido Schmechel commented on patch set 3 01/26/26, 10:43

    Here, too, I would like to see a configurable limit ;-)
  7. Ulrich Mathes uploaded patch set 4 V +1 01/26/26, 13:29

    Add limit configuration
  8. core-ci voted on patch set 4 V +1 01/26/26, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94362

  9. Ulrich Mathes uploaded patch set 5 V +1 01/30/26, 14:43

    Fetch thumbnail size from tsconfig
  10. core-ci voted on patch set 5 V +1 01/30/26, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94679

  11. Peter Kraume voted on patch set 5 CR +1 V +1 02/12/26, 08:12

  12. Nikita Hovratov commented on patch set 5 02/12/26, 08:18

    LargestUnusedFilesWidget.php:103

    Can we extract this into an own service, so it can be used also in other context than dashboard widgets?
  13. Anja Leichsenring voted on patch set 5 CR +1 V +1 02/12/26, 19:37

  14. Anja Leichsenring commented on patch set 5 03/11/26, 19:08

    LargestUnusedFilesWidget.php:103 Reply

    do you have something specific in mind where to use that service? I can't really see any other use case, maybe except in reports? I would prefer not to overengineer that patch for a theoretical improvement that could easily be extracted if it ever is needed anywhere else. Could we agree on that?
  15. Georg Ringer voted on patch set 5 CR +2 V +2 03/12/26, 19:28

  16. Georg Ringer commented on patch set 5 CR +1 V -1 03/12/26, 19:32

    LargestUnusedFilesWidget.php:68

    I am missing the definition for the other options, as those are mentioned in the rst as well. can you please add those as well

    LargestUnusedFilesWidget.php:72

    please use the new API
  17. Ulrich Mathes uploaded patch set 6 CR +1 V +1 03/18/26, 08:50

    Use domain-based translation syntax
  18. core-ci voted on patch set 6 V -1 03/18/26, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98150

  19. Ulrich Mathes uploaded patch set 7 V -1 03/18/26, 10:58

    Clarify widget options and settings
  20. Ulrich Mathes commented on patch set 7 03/18/26, 11:04

    LargestUnusedFilesWidget.php:68 Reply

    You’re right. The widget options and settings weren’t described very clearly. I’ve now provided a more detailed description of the options and settings. The options can be defined by the integrator. I decided to allow users to adjust only the length of the list (within the maximum length defined in the options)

    LargestUnusedFilesWidget.php:72 Reply

    Done

    LargestUnusedFilesWidget.php:103 Reply

    Done
  21. Ulrich Mathes uploaded patch set 8 03/18/26, 11:05

  22. core-ci voted on patch set 7 V -1 03/18/26, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98160

  23. core-ci voted on patch set 8 V +1 03/18/26, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98163

  24. Ulrich Mathes uploaded patch set 9 V +1 03/18/26, 13:26

  25. core-ci voted on patch set 9 V +1 03/18/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98193