Review main Merged

92328[TASK] Streamline test case for FormInlineAjaxController

Oliver Hader CR +2 V +2 Easy +2 −1 updated 01/14/26, 18:31

Commit message

The test case incorrectly searched for `NEW[1-9]+`, but actually
it should have been `NEW[[:alnum:]]+`. Thus, the test returned a
false-positive in the past.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Oliver Hader uploaded patch set 1 01/14/26, 12:27

  2. core-ci voted on patch set 1 V -1 01/14/26, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93437

  3. Oliver Hader uploaded patch set 2 V -1 01/14/26, 14:01

  4. Oliver Hader commented on patch set 2 01/14/26, 14:02

    This change is ready for review.
  5. core-ci voted on patch set 2 V -1 01/14/26, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93447

  6. core-ci commented on patch set 2 01/14/26, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93447

  7. core-ci voted on patch set 2 V +1 01/14/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93447

  8. Georg Ringer voted on patch set 2 CR +1 V +1 01/14/26, 15:03

  9. Oliver Klee voted on patch set 2 CR +1 V +1 01/14/26, 15:03

  10. Christian Kuhn voted on patch set 2 CR +1 V +1 01/14/26, 15:37

  11. Garvin Hicking voted on patch set 2 CR +1 V +1 01/14/26, 18:14

  12. Oliver Hader voted on patch set 2 CR +2 V +2 01/14/26, 18:31

  13. Oliver Hader merged patch set 3 01/14/26, 18:31