92329[BUGFIX] Allow AbstractPart and File in spooled email deserialization
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Elias Häußler +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Elias Häußler +1
- core-ci +1 CI
Issues 2
Files 3
Review log 4863
Show 3038 earlier messages
-
Markus Klein uploaded patch set 1 01/14/26, 13:43
-
Markus Klein uploaded patch set 2 01/14/26, 13:45
-
Markus Klein updated the commit message in patch set 3 01/14/26, 13:46
-
core-ci voted on patch set 1 V +1 01/14/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93442
-
core-ci voted on patch set 2 V +1 01/14/26, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93443
-
core-ci voted on patch set 3 V +1 01/14/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93444
-
Elias Häußler commented on patch set 3 01/14/26, 16:19
Can we have a test case to verify that the .sending file is actually NOT deleted on transport failure? I can take care of that later today, if no one else is faster. -
Elias Häußler uploaded patch set 4
V +101/14/26, 17:32 -
Elias Häußler commented on patch set 4 01/14/26, 17:33
Reply
Done -
Elias Häußler voted on patch set 4 CR +1 V +1 01/14/26, 17:37
-
core-ci voted on patch set 4 V +1 01/14/26, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93467
-
Andreas Kienast voted on patch set 4 CR +1 01/15/26, 06:49
-
Markus Klein commented on patch set 4 01/15/26, 08:14
Reply
Thanks, thought about a test too, but didn't have the time yesterday. -
Oliver Klee voted on patch set 4 V +1 01/15/26, 09:05
-
Markus Klein commented on patch set 4 01/15/26, 15:16
FileSpoolTest.php:120strange, this fails on v12 in the CI https://git.typo3.org/typo3/CI/cms/-/jobs/5200185 The created exception contains no 10 digit exception code as second argument, in or below this line: sysext/core/Tests/Unit/Mail/FileSpoolTest.php:4418:new RuntimeException('Transport failure')); -
Elias Häußler uploaded patch set 5
CR +1V +101/15/26, 15:35 -
Elias Häußler commented on patch set 5 01/15/26, 15:35
FileSpoolTest.php:120ReplyDone, can you try again with v12? -
Elias Häußler commented on patch set 5 01/15/26, 15:36
I assume there won't be another v14.0 release, since v14.1 is already released next Tuesday. But I'm not sure here, maybe someone can confirm? -
core-ci voted on patch set 5 V +1 01/15/26, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93525
-
Andreas Kienast commented on patch set 5 01/15/26, 15:44
Reply
AFAIK this will go into 14.1 (aka "main" right now). -
Oliver Klee voted on patch set 5 V +1 01/15/26, 15:44
-
Elias Häußler updated the commit message in patch set 6
V +101/15/26, 15:45 -
Elias Häußler commented on patch set 6 01/15/26, 15:45
Reply
Done -
Oliver Klee voted on patch set 6 V +1 01/15/26, 15:53
-
core-ci voted on patch set 6 V +1 01/15/26, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93526
-
Markus Klein commented on patch set 6 01/15/26, 16:12
FileSpoolTest.php:120Replyupdated the cherry-pick. but I wonder why we have different rules for exceptions in v12 and v14. -
Markus Klein commented on patch set 6 01/15/26, 16:51
FileSpoolTest.php:120ReplyDone -
Elias Häußler voted on patch set 6 CR +1 V +1 01/15/26, 17:06
-
Markus Klein commented on patch set 6 CR -1 V -1 01/16/26, 09:05
FileSpool.php:162I'd drop this or rename the file to something different. it makes debugging impossible, if we delete the root cause. we just had this exception in production, which we patched already -
Markus Klein commented on patch set 6 01/16/26, 09:08
FileSpool.php:162```suggestion rename($file . '.sending', $file . '.invalid'); ``` -
Markus Klein uploaded patch set 7
CR +1V +101/16/26, 09:10 -
Markus Klein commented on patch set 7 01/16/26, 09:11
FileSpool.php:162ReplyDone -
core-ci voted on patch set 7 V +1 01/16/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93569
-
Markus Klein commented on patch set 7 01/16/26, 09:53
FileSpool.php:162ReplyDone -
Markus Klein uploaded patch set 8
V +101/16/26, 10:03 -
Markus Klein uploaded patch set 9 01/16/26, 10:10
-
Markus Klein updated the commit message in patch set 10 01/16/26, 10:15
-
core-ci voted on patch set 8 V -1 01/16/26, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93576
-
Markus Klein uploaded patch set 11 01/16/26, 10:16
-
core-ci voted on patch set 9 V -1 01/16/26, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93580
-
core-ci voted on patch set 11 V -1 01/16/26, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93582
-
core-ci voted on patch set 10 V -1 01/16/26, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93581
-
Markus Klein uploaded patch set 12
V -101/16/26, 12:09 -
Oliver Hader updated the commit message in patch set 13 01/16/26, 12:18
-
core-ci voted on patch set 12 V +1 01/16/26, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93595
-
core-ci voted on patch set 13 V +1 01/16/26, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93600
-
Oliver Hader voted on patch set 13 CR +1 01/16/26, 12:34
-
Johannes Kasberger voted on patch set 13 CR +1 V +1 01/16/26, 13:30
-
Elias Häußler commented on patch set 13 CR -1 01/16/26, 13:31
As we pretty much depend on an external library (Symfony) when deciding which classes and instances to whitelist for the `unserialize` function, I see it as an important measure to add a test case for the scenario that is fixed by this patch (having attachments in place). I'll take care of that... -
Elias Häußler uploaded patch set 14
CR +1V +101/16/26, 13:44 -
Elias Häußler commented on patch set 14 CR +1 V +1 01/16/26, 13:45
Reply
Done -
Johannes Kasberger voted on patch set 14 CR +1 V +1 01/16/26, 13:46
-
Markus Klein commented on patch set 14 01/16/26, 13:50
FileSpoolTest.php:161this should be ```suggestion $email->embed('foo'); ``` because attach is the same as attachfrompath -
core-ci voted on patch set 14 V +1 01/16/26, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93605
-
Elias Häußler commented on patch set 14 01/16/26, 13:55
FileSpoolTest.php:161ReplyThe only difference between `attach` and `attachFromPath` for our use-case is that [`attach` adds the body as-is](https://github.com/symfony/symfony/blob/v7.4.3/src/Symfony/Component/Mime/Email.php#L334), while [`attachFromPath` wraps it in a `File` object](https://github.com/symfony/symfony/blob/v7.4.3/src/Symfony/Component/Mime/Email.php#L342), which is what we want to test here. I agree that the naming `inline` is misleading here, but I'd keep the implementation as-is. -
Elias Häußler uploaded patch set 15
CR +1V +101/16/26, 13:59 -
core-ci voted on patch set 15 V +1 01/16/26, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93606
-
Markus Klein commented on patch set 15 01/16/26, 14:08
FileSpoolTest.php:161ReplyAcknowledged -
Oliver Hader voted on patch set 15 CR +1 01/16/26, 15:07
-
Elias Häußler voted on patch set 15 CR +1 V +1 01/16/26, 16:14
-
Oliver Klee voted on patch set 15 V +1 01/16/26, 16:51
-
Benjamin Franzke voted on patch set 15 CR +2 V +2 01/19/26, 07:38
-
Benjamin Franzke merged patch set 16 01/19/26, 09:43