92332[BUGFIX] Remove uppercase restriction from PAGEVIEW
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Oli Bartsch +1
- Garvin Hicking +1
-
Verified V +2 Done
- Simon Praetorius +2
- Oli Bartsch +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php+5 −4
- typo3/sysext/frontend/Tests/Functional/ContentObject/Fixtures/FluidPage/pages.csv+1 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.php2+41 −10
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/page.tsconfig+22 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Templates/Pages/special_layout.htmlnew+7 −0
Review log 1318
-
Simon Praetorius uploaded patch set 1 01/14/26, 15:12
-
core-ci voted on patch set 1 V -1 01/14/26, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93457
-
Simon Schaufelberger commented on patch set 1 01/14/26, 15:33
-
Simon Praetorius uploaded patch set 2
V -101/14/26, 17:04 -
core-ci voted on patch set 2 V +1 01/14/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93463
-
Simon Praetorius uploaded patch set 3
V +101/14/26, 17:13 -
Simon Praetorius commented on patch set 3 01/14/26, 17:16
PageViewContentObjectTest.php:37ReplyDone -
core-ci voted on patch set 3 V +1 01/14/26, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93464
-
Garvin Hicking voted on patch set 3 CR +1 V +1 01/14/26, 17:27
-
Oli Bartsch commented on patch set 3 01/14/26, 20:42
I have checked the test and it also passes without the changes in PageViewContentObject -
Oli Bartsch uploaded patch set 4
CR +1V +101/14/26, 21:02 -
Oli Bartsch uploaded patch set 5 01/14/26, 21:02
-
core-ci voted on patch set 5 V +1 01/14/26, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93478
-
core-ci voted on patch set 4 V -1 01/14/26, 21:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93477
-
Oli Bartsch commented on patch set 5 CR +1 V +1 01/14/26, 21:16
Reply
Done -
Garvin Hicking voted on patch set 5 CR +1 V +1 01/14/26, 21:33
-
Simon Praetorius voted on patch set 5 CR +2 V +2 01/14/26, 21:35
-
Simon Praetorius merged patch set 6 01/14/26, 21:35
PageViewContentObjectTest.php:37