Review main Merged

92332[BUGFIX] Remove uppercase restriction from PAGEVIEW

Simon Praetorius CR +2 V +2 Normal +76 −14 updated 01/14/26, 21:35

Commit message

The PAGEVIEW content object had a hard requirement for page template
files (determined by the backend layout of the page) to start with
an uppercase character. Since Fluid 5, there is a fallback chain in
place, which makes this requirement obsolete and allows us to support
both uppercase and lowercase file names.

Note that this change cannot be backported to v13 since it would be
a breaking change due to the missing fallback chain.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1318

  1. Simon Praetorius uploaded patch set 1 01/14/26, 15:12

  2. core-ci voted on patch set 1 V -1 01/14/26, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93457

  3. Simon Schaufelberger commented on patch set 1 01/14/26, 15:33

    PageViewContentObjectTest.php:37

    both constants can be private. Actually this should be detected by php-cs-fixer but it seams it doesn't work.
  4. Simon Praetorius uploaded patch set 2 V -1 01/14/26, 17:04

  5. core-ci voted on patch set 2 V +1 01/14/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93463

  6. Simon Praetorius uploaded patch set 3 V +1 01/14/26, 17:13

  7. Simon Praetorius commented on patch set 3 01/14/26, 17:16

    PageViewContentObjectTest.php:37 Reply

    Done
  8. core-ci voted on patch set 3 V +1 01/14/26, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93464

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 01/14/26, 17:27

  10. Oli Bartsch commented on patch set 3 01/14/26, 20:42

    I have checked the test and it also passes without the changes in PageViewContentObject
  11. Oli Bartsch uploaded patch set 4 CR +1 V +1 01/14/26, 21:02

  12. Oli Bartsch uploaded patch set 5 01/14/26, 21:02

  13. core-ci voted on patch set 5 V +1 01/14/26, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93478

  14. core-ci voted on patch set 4 V -1 01/14/26, 21:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93477

  15. Oli Bartsch commented on patch set 5 CR +1 V +1 01/14/26, 21:16

    Reply

    Done
  16. Garvin Hicking voted on patch set 5 CR +1 V +1 01/14/26, 21:33

  17. Simon Praetorius voted on patch set 5 CR +2 V +2 01/14/26, 21:35

  18. Simon Praetorius merged patch set 6 01/14/26, 21:35