Review main Merged

92335[TASK] Clean up BreadcrumbFactory

Christian Kuhn CR +2 V +2 Easy +15 −17 updated 01/14/26, 21:06

Commit message

* Class does not need to be public:true since it is always injected
* Class can be easily made readonly by injecting LoggerInterface
  instead of using the trait
* Null safe operator on $this->logger is not needed with proper
  injection
* Add @todo for two potentially risky catch \Exception cases

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 01/14/26, 20:12

  2. core-ci voted on patch set 1 V +1 01/14/26, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93474

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 01/14/26, 20:29

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 01/14/26, 20:47

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 01/14/26, 21:02

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 01/14/26, 21:06

  7. Christian Kuhn merged patch set 2 01/14/26, 21:06