Review main Merged

92337[TASK] Clean up PageInformationController

Christian Kuhn CR +2 V +2 Hard +317 −318 updated 01/15/26, 09:09

Commit message

Evening work of a "we can not keep it like that" controller. The
PageInformationController (Status Module -> Pagetree Overview)
did not receive too much love over the years since we had to do
our homework with the surrounding class construct handling the
former "Info" module and its module API first.

The patch cleans up the outer part of the class by removing the
inheritance from InfoModuleController: controller-to-controller
inheritance reliably creates mess, this case is a great example.

Entry method handleRequest() is streamlined, a few helper methods
are dissolved, the class is now readonly and stateless to isolate
methods from each other, and some surrounding details are adapted
as drive-by.

The main content generation is mainly kept as-is. This area
deserves a separation of data preparation to be kept in PHP
with HTML creation being extracted to templates. This should
be much easier with the outer code being dealt with now. The
patch might be a kickstart to rethink this view altogether and
modernize it as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Christian Kuhn uploaded patch set 1 01/14/26, 22:47

  2. core-ci voted on patch set 1 V +1 01/14/26, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93479

  3. Christian Kuhn updated the commit message in patch set 2 V +1 01/14/26, 23:06

  4. Christian Kuhn uploaded patch set 3 01/14/26, 23:10

  5. core-ci voted on patch set 2 V +1 01/14/26, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93480

  6. core-ci voted on patch set 3 V +1 01/14/26, 23:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93481

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 01/14/26, 23:23

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/15/26, 06:32

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 01/15/26, 09:09

  10. Christian Kuhn merged patch set 4 01/15/26, 09:09