Review main Merged

92339[TASK] Streamline PDF page parsing in ext:indexed_search

TYPO3com CR +2 V +2 Easy +7 −5 updated 09/03/26, 12:56

Commit message

This change streamlines the internal API at
FileContentParser::readFileContent when parsing PDF files.
Claims that it would be a "security vulnerability" are not
correct, since the internal processing relies on sanitized
data from FileContentParser::fileContentParts.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1826

Show 01 earlier messages
  1. TYPO3com uploaded patch set 1 01/15/26, 11:05

  1. Simon Schaufelberger commented on patch set 1 01/15/26, 11:11

    @oliver.hader@typo3.org probably interesting for you. I guess this can also be backported?
  2. core-ci voted on patch set 1 V +1 01/15/26, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93508

  3. Oliver Hader wrote 01/15/26, 11:30

    Set private
  4. Oliver Hader commented on patch set 1 01/15/26, 12:21

    *No Vulnerability*, see analysis at https://github.com/TYPO3/typo3/blob/v13.4.23/typo3/sysext/indexed_search/Classes/FileContentParser.php#L749-L753 However, the internal API can be adjusted and hardened further.
  5. Oliver Hader wrote 01/15/26, 12:22

    Unset private
  6. Oliver Hader marked it work in progress 01/15/26, 12:23

  7. Mathias Brodala commented on patch set 1 01/15/26, 12:25

    FileContentParser.php:461 Unresolved

    The already float values are re-casted to int here. Does someone know why they are not int in the first place? Surely pdftotext does not support fractional pages, does it?
  8. Oliver Hader commented on patch set 1 01/15/26, 12:25

    FileContentParser.php:474

    In general all arguments should be passed through `escapeshellarg` (even if additionally casted)
  9. Simon Schaufelberger wrote 01/15/26, 14:44

    Removed cc Simon Schaufelberger.
  10. Oliver Hader uploaded patch set 2 V +1 01/16/26, 10:26

  11. Oliver Hader commented on patch set 2 01/16/26, 10:27

    This change is ready for review.

    FileContentParser.php:474 Reply

    Done
  12. core-ci voted on patch set 2 V +1 01/16/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93584

  13. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:26

  14. core-ci voted on patch set 3 V -1 04/22/26, 06:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100697

  15. Benni Mack rebased onto patch set 4 V -1 09/02/26, 14:01

  16. core-ci voted on patch set 4 V +1 09/02/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107638

  17. Benni Mack updated the commit message in patch set 5 V +1 09/02/26, 14:13

  18. core-ci voted on patch set 5 V +1 09/02/26, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107640

  19. Georg Ringer updated the commit message in patch set 6 V +1 09/02/26, 16:48

  20. Benni Mack updated the commit message in patch set 7 09/02/26, 16:57

  21. core-ci voted on patch set 7 V +1 09/02/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107664

  22. core-ci voted on patch set 6 V +1 09/02/26, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107659

  23. Benni Mack voted on patch set 7 CR +1 V +1 09/03/26, 12:41

  24. Georg Ringer voted on patch set 7 CR +2 V +2 09/03/26, 12:43

  25. Georg Ringer merged patch set 8 09/03/26, 12:56