92341[TASK] Allow activating default theme in installation process
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Configuration/SiteWriter.php+7 −3
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+1 −1
- typo3/sysext/install/Classes/Command/SetupCommand.php3+16 −2
- typo3/sysext/install/Classes/Controller/InstallerController.php+19 −4
- typo3/sysext/install/Classes/Service/SetupService.php4+122 −17
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDefaultConfiguration.fluid.html2+23 −10
Review log 1825
-
Oli Bartsch uploaded patch set 1 01/15/26, 12:23
-
Benjamin Franzke commented on patch set 1 01/15/26, 12:31
-
core-ci voted on patch set 1 V +1 01/15/26, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93513
-
Garvin Hicking commented on patch set 1 01/15/26, 15:45
Default.html:6Should this use f:translate and a localized message for sites configured as german or so?ShowDefaultConfiguration.fluid.html:51should we display the default theme name/key here so in future versions it will use different theme names and establish the concept of future different theme names? -
Oli Bartsch commented on patch set 1 01/15/26, 20:38
Default.html:6ReplyThe default site does only have English language.ShowDefaultConfiguration.fluid.html:51ReplyYes sure, as soon as we have an API for this. There is currently no way to get the "theme name". -
Oli Bartsch uploaded patch set 2
V +101/16/26, 09:18 -
core-ci voted on patch set 2 V +1 01/16/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93570
-
Oli Bartsch uploaded patch set 3
V +101/16/26, 09:46 -
Oli Bartsch commented on patch set 3 01/16/26, 09:47
setup.typoscript:1ReplyDone -
core-ci voted on patch set 3 V -1 01/16/26, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93572
-
Oli Bartsch uploaded patch set 4
V -101/16/26, 10:06 -
core-ci voted on patch set 4 V +1 01/16/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93578
-
Oli Bartsch uploaded patch set 5
V +101/16/26, 12:08 -
Oli Bartsch uploaded patch set 6 01/16/26, 12:13
-
core-ci voted on patch set 5 V -1 01/16/26, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93594
-
core-ci voted on patch set 6 V +1 01/16/26, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93598
-
Benjamin Franzke commented on patch set 6 01/16/26, 12:47
SetupCommand.php:262Opinion: I'd vote for dropping the option to create a site if neither camino nor FSC are installed and avoid creating the useless sys_template dummy.SetupService.php:102We could also include `typo3/fluid-styled-content-css` here additionally.SetupService.php:252Closing `</p>` but not an opening `<p>` here. -
Benjamin Franzke commented on patch set 6 01/16/26, 12:47
Awesome, works for me with and without camino installed 👍 -
Benjamin Franzke uploaded patch set 7
V +101/16/26, 12:56 -
Benjamin Franzke commented on patch set 7 01/16/26, 12:56
SetupService.php:102ReplyDoneSetupService.php:252ReplyDone -
core-ci voted on patch set 7 V +1 01/16/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93602
-
Garvin Hicking commented on patch set 7 CR +1 V +1 01/16/26, 13:46
works for me in different permutations (composer / classic mode) -
Oli Bartsch commented on patch set 7 01/16/26, 15:54
SetupCommand.php:262ReplyI personally like to have, even without fsc and camino, the option to not face an error message on opening the backend for the first time. I would like to not break this behaviour with this patch. I'm completely open to discuss this again after v14.1 release. Mmaybe we will find even a better alternative. I hope this is fine for you. -
Benjamin Franzke commented on patch set 7 CR +2 V +2 01/16/26, 16:19
SetupCommand.php:262ReplyAcknowledged -
Benjamin Franzke merged patch set 8 01/16/26, 16:19
setup.typoscript:1