Review main Merged

92341[TASK] Allow activating default theme in installation process

Oli Bartsch CR +2 V +2 Normal +190 −39 updated 01/16/26, 16:19

Commit message

The final installation step has been modernized to allow creating
a page with the default theme. Internally, the corresponding site set
is added to the newly created site. The same approach is applied to
fluid_styled_content to avoid legacy, hard coded sys_template usage,
which is now only used as a last fallback.

If a default theme is available, this option is
preferred over "take me straight to the backend".

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1825

  1. Oli Bartsch uploaded patch set 1 01/15/26, 12:23

  2. Benjamin Franzke commented on patch set 1 01/15/26, 12:31

    setup.typoscript:1

    We could write this content into `config/sites/{identifier}/setup.typoscript`, otherwise this becomes FSC API, which we probably do not want right now. The `SetupService` that can make use of the already existing `typo3/fluid-styled-content` set and we avoid introducing a new set.
  3. core-ci voted on patch set 1 V +1 01/15/26, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93513

  4. Garvin Hicking commented on patch set 1 01/15/26, 15:45

    Default.html:6

    Should this use f:translate and a localized message for sites configured as german or so?

    ShowDefaultConfiguration.fluid.html:51

    should we display the default theme name/key here so in future versions it will use different theme names and establish the concept of future different theme names?
  5. Oli Bartsch commented on patch set 1 01/15/26, 20:38

    Default.html:6 Reply

    The default site does only have English language.

    ShowDefaultConfiguration.fluid.html:51 Reply

    Yes sure, as soon as we have an API for this. There is currently no way to get the "theme name".
  6. Oli Bartsch uploaded patch set 2 V +1 01/16/26, 09:18

  7. core-ci voted on patch set 2 V +1 01/16/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93570

  8. Oli Bartsch uploaded patch set 3 V +1 01/16/26, 09:46

  9. Oli Bartsch commented on patch set 3 01/16/26, 09:47

    setup.typoscript:1 Reply

    Done
  10. core-ci voted on patch set 3 V -1 01/16/26, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93572

  11. Oli Bartsch uploaded patch set 4 V -1 01/16/26, 10:06

  12. core-ci voted on patch set 4 V +1 01/16/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93578

  13. Oli Bartsch uploaded patch set 5 V +1 01/16/26, 12:08

  14. Oli Bartsch uploaded patch set 6 01/16/26, 12:13

  15. core-ci voted on patch set 5 V -1 01/16/26, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93594

  16. core-ci voted on patch set 6 V +1 01/16/26, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93598

  17. Benjamin Franzke commented on patch set 6 01/16/26, 12:47

    SetupCommand.php:262

    Opinion: I'd vote for dropping the option to create a site if neither camino nor FSC are installed and avoid creating the useless sys_template dummy.

    SetupService.php:102

    We could also include `typo3/fluid-styled-content-css` here additionally.

    SetupService.php:252

    Closing `</p>` but not an opening `<p>` here.
  18. Benjamin Franzke commented on patch set 6 01/16/26, 12:47

    Awesome, works for me with and without camino installed 👍
  19. Benjamin Franzke uploaded patch set 7 V +1 01/16/26, 12:56

  20. Benjamin Franzke commented on patch set 7 01/16/26, 12:56

    SetupService.php:102 Reply

    Done

    SetupService.php:252 Reply

    Done
  21. core-ci voted on patch set 7 V +1 01/16/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93602

  22. Garvin Hicking commented on patch set 7 CR +1 V +1 01/16/26, 13:46

    works for me in different permutations (composer / classic mode)
  23. Oli Bartsch commented on patch set 7 01/16/26, 15:54

    SetupCommand.php:262 Reply

    I personally like to have, even without fsc and camino, the option to not face an error message on opening the backend for the first time. I would like to not break this behaviour with this patch. I'm completely open to discuss this again after v14.1 release. Mmaybe we will find even a better alternative. I hope this is fine for you.
  24. Benjamin Franzke commented on patch set 7 CR +2 V +2 01/16/26, 16:19

    SetupCommand.php:262 Reply

    Acknowledged
  25. Benjamin Franzke merged patch set 8 01/16/26, 16:19