92352[TASK] Streamline naming of CType / Content Element
Commit message
Review
-
Code review CR +1
- Benjamin Franzke +1
- Josua Vogel +1
- Benjamin Kott +1
-
Verified V +1
- Benjamin Franzke +1
- Josua Vogel +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+6 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTtContentColPosItemsRestrictionByBackendLayout.php+10 −10
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTtContentCtypeItemsRestrictionByBackendLayout.php+10 −10
- typo3/sysext/backend/Classes/Hooks/DataHandlerContentElementRestrictionHook.php+10 −10
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+6 −6
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementControllerTest.php+4 −4
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108623-AllowContentElementRestrictionsPerColPos.rst+42 −9
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+2 −2
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+2 −2
Review log 1825
-
Garvin Hicking uploaded patch set 1 01/16/26, 13:27
-
core-ci voted on patch set 1 V -1 01/16/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93604
-
Benjamin Franzke commented on patch set 1 01/16/26, 13:46
Let's use `allowedContentElements` as a generic term, that does not care about database values, but logical names. We should even make this configurable for integrations in order to allow extensions like `content_blocks` to hook in and allow their logical names (e.g. `vendor/my-content-block`, not the technical database values) to be provided. For that reason – using logical names – I vote for: `allowedContentElements` -
Benjamin Franzke commented on patch set 1 01/16/26, 13:47
Reply
Reason why to use logical names instead of database values: Make the life of our integrators as easy and straightforward as possible. -
Garvin Hicking commented on patch set 1 01/16/26, 14:20
Reply
I will create a second patchset with this variant, then we can pick + choose. -
Garvin Hicking uploaded patch set 2
V -101/16/26, 14:22 -
Garvin Hicking uploaded patch set 3 01/16/26, 14:29
alternate reality -
core-ci voted on patch set 2 V +1 01/16/26, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93611
-
Garvin Hicking uploaded patch set 4 01/16/26, 14:31
the leftovers -
Garvin Hicking commented on patch set 4 01/16/26, 14:33
Reply
Done; feel free to push over the iterations on patchset 2 or 4 for details. -
core-ci voted on patch set 3 V +1 01/16/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93612
-
core-ci voted on patch set 4 V +1 01/16/26, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93613
-
Josua Vogel commented on patch set 4 01/16/26, 14:48
SetupServiceTest.php:127```suggestion public function createBackendUserGroupsCreatesGroupsWithAllowedContentElements(): void ``` -
Benjamin Franzke uploaded patch set 5
V +101/16/26, 16:40 -
Benjamin Franzke commented on patch set 5 01/16/26, 16:40
Reply
Thanks!SetupServiceTest.php:127ReplyDone -
Benjamin Franzke voted on patch set 5 CR 0 V 0 01/16/26, 16:45
-
core-ci voted on patch set 5 V +1 01/16/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93617
-
Oliver Klee voted on patch set 5 CR +1 01/16/26, 16:50
-
Benjamin Franzke uploaded patch set 6
CR +1V +101/16/26, 16:51s/allowedContentElements/allowedContent/ -
core-ci voted on patch set 6 V -1 01/16/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93619
-
Benjamin Franzke voted on patch set 6 CR +1 V +1 01/16/26, 17:34
-
core-ci voted on patch set 6 V +1 01/16/26, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93619
-
Benjamin Kott voted on patch set 6 CR +1 V +1 01/16/26, 19:58
-
Josua Vogel voted on patch set 6 CR +1 V +1 01/16/26, 22:13
-
Benjamin Kott abandoned the change 01/19/26, 08:10
core-mergers discussed this change and decided to stick to allowedContentTypes