Review main Abandoned

92352[TASK] Streamline naming of CType / Content Element

Garvin Hicking CR +1 V +1 Normal +93 −60 updated 01/19/26, 08:10

Commit message

With #108623 new restriction-based definition for creating
content elements was introduced.

The internal key "CType" (likely implying "Content type") was
the main reason for naming the new typoscript key
"allowedContentTypes".

However, the term "content types" is not aligning with goals
of the initiative to streamline terms distinctive to TYPO3
with more broadly known terms. For this, the simple term
"Content" would be preferred.

This patch tries to establish this terminology and thus
renames:

- allowedContentTypes -> allowedContent
- disallowedContentTypes -> disallowedContent

Review

  • Code review CR +1
    • Benjamin Franzke +1
    • Josua Vogel +1
    • Benjamin Kott +1
  • Verified V +1
    • Benjamin Franzke +1
    • Josua Vogel +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 1825

  1. Garvin Hicking uploaded patch set 1 01/16/26, 13:27

  2. core-ci voted on patch set 1 V -1 01/16/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93604

  3. Benjamin Franzke commented on patch set 1 01/16/26, 13:46

    Let's use `allowedContentElements` as a generic term, that does not care about database values, but logical names. We should even make this configurable for integrations in order to allow extensions like `content_blocks` to hook in and allow their logical names (e.g. `vendor/my-content-block`, not the technical database values) to be provided. For that reason – using logical names – I vote for: `allowedContentElements`
  4. Benjamin Franzke commented on patch set 1 01/16/26, 13:47

    Reply

    Reason why to use logical names instead of database values: Make the life of our integrators as easy and straightforward as possible.
  5. Garvin Hicking commented on patch set 1 01/16/26, 14:20

    Reply

    I will create a second patchset with this variant, then we can pick + choose.
  6. Garvin Hicking uploaded patch set 2 V -1 01/16/26, 14:22

  7. Garvin Hicking uploaded patch set 3 01/16/26, 14:29

    alternate reality
  8. core-ci voted on patch set 2 V +1 01/16/26, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93611

  9. Garvin Hicking uploaded patch set 4 01/16/26, 14:31

    the leftovers
  10. Garvin Hicking commented on patch set 4 01/16/26, 14:33

    Reply

    Done; feel free to push over the iterations on patchset 2 or 4 for details.
  11. core-ci voted on patch set 3 V +1 01/16/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93612

  12. core-ci voted on patch set 4 V +1 01/16/26, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93613

  13. Josua Vogel commented on patch set 4 01/16/26, 14:48

    SetupServiceTest.php:127

    ```suggestion public function createBackendUserGroupsCreatesGroupsWithAllowedContentElements(): void ```
  14. Benjamin Franzke uploaded patch set 5 V +1 01/16/26, 16:40

  15. Benjamin Franzke commented on patch set 5 01/16/26, 16:40

    Reply

    Thanks!

    SetupServiceTest.php:127 Reply

    Done
  16. Benjamin Franzke voted on patch set 5 CR 0 V 0 01/16/26, 16:45

  17. core-ci voted on patch set 5 V +1 01/16/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93617

  18. Oliver Klee voted on patch set 5 CR +1 01/16/26, 16:50

  19. Benjamin Franzke uploaded patch set 6 CR +1 V +1 01/16/26, 16:51

    s/allowedContentElements/allowedContent/
  20. core-ci voted on patch set 6 V -1 01/16/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93619

  21. Benjamin Franzke voted on patch set 6 CR +1 V +1 01/16/26, 17:34

  22. core-ci voted on patch set 6 V +1 01/16/26, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93619

  23. Benjamin Kott voted on patch set 6 CR +1 V +1 01/16/26, 19:58

  24. Josua Vogel voted on patch set 6 CR +1 V +1 01/16/26, 22:13

  25. Benjamin Kott abandoned the change 01/19/26, 08:10

    core-mergers discussed this change and decided to stick to allowedContentTypes