92355[TASK] Prevent disallowed named arguments usage using phpstan
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 49
- Build/phpstan/src/Rules/Classes/NamedArgumentUsageRule.phpnew+166 −0
- Build/phpstan/tests/Rules/Classes/NamedArgumentUsageRule/Fixtures/ConstructorFixture.phpnew+28 −0
- Build/phpstan/tests/Rules/Classes/NamedArgumentUsageRule/Fixtures/NamedArgumentFixture.phpnew+62 −0
- Build/phpstan/tests/Rules/Classes/NamedArgumentUsageRule/Source/ConstructorWithNamedArguments.phpnew+23 −0
- Build/phpstan/tests/Rules/Classes/NamedArgumentUsageRule/NamedArgumentUsageRuleTest.phpnew+57 −0
- Build/phpstan/phpstan.neon2+9 −0
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkService.php+4 −4
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+3 −3
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+3 −3
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+3 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+3 −3
- typo3/sysext/backend/Classes/Controller/LoginController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaController.php+7 −5
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+3 −3
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −5
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SubmoduleOverviewController.php+2 −2
- typo3/sysext/backend/Classes/Localization/ManualLocalizationHandler.php+6 −6
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php+2 −2
Show 29 more files
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+2 −2
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+21 −21
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+3 −3
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+3 −3
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+3 −3
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+3 −3
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+3 −3
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/BackendModuleProvider.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+3 −3
- typo3/sysext/lowlevel/Classes/Controller/QuerySearchController.php+3 −3
- typo3/sysext/lowlevel/Classes/Controller/RawSearchController.php+2 −2
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+3 −3
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+3 −3
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+2 −2
- typo3/sysext/redirects/Classes/Service/SlugService.php+2 −2
- typo3/sysext/reports/Classes/Controller/RecordStatisticsController.php+2 −2
- typo3/sysext/reports/Classes/Controller/StatusReportController.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+2 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
- typo3/sysext/styleguide/Classes/Controller/ComponentsController.php+3 −3
- typo3/sysext/styleguide/Classes/Controller/PageTreesController.php+3 −3
- typo3/sysext/styleguide/Classes/Controller/StylesController.php+3 −3
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+3 −3
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+3 −3
- typo3/sysext/webhooks/Classes/Controller/ManagementController.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+3 −3
Review log 1928
Show 23 earlier messages
-
Simon Schaufelberger uploaded patch set 1 01/16/26, 20:35
-
Simon Schaufelberger marked it work in progress 01/16/26, 20:35
-
core-ci voted on patch set 1 V -1 01/16/26, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93631
-
Simon Schaufelberger uploaded patch set 2
V -101/16/26, 20:59 -
core-ci voted on patch set 2 V +1 01/16/26, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93634
-
Simon Schaufelberger uploaded patch set 3
V +103/10/26, 20:55 -
core-ci voted on patch set 3 V -1 03/10/26, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97721
-
Christian Kuhn commented on patch set 3 03/10/26, 21:38
it looks to me as if the violations i was aware of are caught by this change. as such, i'm of the opinion that we should get this one done. -
Simon Schaufelberger uploaded patch set 4
V -103/10/26, 22:58 -
Simon Schaufelberger commented on patch set 4 03/10/26, 22:59
This change is ready for review. -
Simon Schaufelberger commented on patch set 4 03/10/26, 23:07
phpstan.neon:22the indentation is different here as the whole file is with spaces BUT in .editorconfig it is configured as: ``` [*.neon] indent_size = 2 indent_style = tab ``` -
core-ci voted on patch set 4 V +1 03/10/26, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97724
-
Oliver Klee voted on patch set 4 V +1 03/11/26, 08:15
-
Christian Kuhn uploaded patch set 5
V +103/13/26, 10:35 -
Christian Kuhn commented on patch set 5 03/13/26, 10:36
phpstan.neon:22Replylet's ignore this if possible with this patch for now. -
Christian Kuhn uploaded patch set 6 03/13/26, 10:40
-
Christian Kuhn updated the commit message in patch set 7 03/13/26, 10:41
-
Christian Kuhn updated the commit message in patch set 8 03/13/26, 10:48
-
Christian Kuhn uploaded patch set 9 03/13/26, 10:49
-
core-ci voted on patch set 5 V -1 03/13/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97878
-
core-ci voted on patch set 9 V +1 03/13/26, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97883
-
Christian Kuhn voted on patch set 9 CR +1 V +1 03/13/26, 11:09
-
core-ci voted on patch set 6 V -1 03/13/26, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97879
-
core-ci voted on patch set 7 V -1 03/13/26, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97880
-
Stefan Bürk voted on patch set 9 CR +1 V +1 03/13/26, 11:27
-
core-ci voted on patch set 8 V -1 03/13/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97882
-
Christian Kuhn voted on patch set 9 CR +2 V +2 03/13/26, 11:41
-
Christian Kuhn merged patch set 10 03/13/26, 11:41