Review main Abandoned

92360[WIP][FEATURE] Add event to modify max upload file size

Sebastian Michaelsen CR 0 V 0 Normal +114 −0 updated 09/29/26, 13:00

Commit message

Adds a new PSR-14 event to modify the maximum allowed file upload size.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Sebastian Michaelsen uploaded patch set 1 01/16/26, 23:22

  2. Sebastian Michaelsen uploaded patch set 2 01/16/26, 23:23

  3. Sebastian Michaelsen uploaded patch set 3 01/16/26, 23:24

  4. core-ci voted on patch set 1 V +1 01/16/26, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93647

  5. core-ci voted on patch set 2 V +1 01/16/26, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93648

  6. core-ci voted on patch set 3 V +1 01/16/26, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93649

  7. Garvin Hicking commented on patch set 3 01/17/26, 00:32

    Unresolved

    Thanks for offering an implementation of this! Please add a commit message describing the change. Maybe you want to set the patch as `[WIP]` or mark it as work-in-progress if this is not yet your final proposal? We also need tests for the event, similar to existing PSR-14 events. And the changelog would need to mention an example listener implementation. You can see the ReST files of other introduced PSR-14 events for guidance. Also, there are more places where the upload limit is exposed/utilized (MaximumFileSizeViewHelper, FilesControlContainer, Http/UploadedFile, FileListController, CreateFileBrowser). I think these should also utilize the event then. The event would then also need to have some kind of "source" so that listeners could act on each specific instance.

    ModifyMaxUploadFileSize.php:23 Unresolved

    Please use `ModifyMaxUploadFileSizeEvent` for this to adhere to the PSR-14 event naming scheme of the core. Also, please make it a final class.

    ResourceStorage.php:993 Unresolved

    I think this needs to throw exception in case events set a higher upload limit than PHP allows. It must be ensured that only a lower limit is set.

    Feature-108660-AddPSR-14EventModifyMaxUploadFileSize.rst:6 Unresolved

    copy pasta leftover

    Feature-108660-AddPSR-14EventModifyMaxUploadFileSize.rst:26 Unresolved

    copy pasta leftovers :)
  8. Sebastian Michaelsen uploaded patch set 4 V +1 01/19/26, 07:46

  9. core-ci voted on patch set 4 V +1 01/19/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93752

  10. Georg Ringer commented on patch set 4 01/19/26, 08:13

    just as an idea: could we move the event somewhere else and call it a more general name - so it could be used to skip files either e.g. because of size or also because, maybe its content is problematic - checked by some 3rd party tool, copyright issues or whatever? what do you think?
  11. Sebastian Michaelsen marked it work in progress 03/22/26, 12:18

  12. Sebastian Michaelsen commented on patch set 4 09/29/26, 13:00

    Thank you for your reviews, I'll abandon this change and issue in favor of #110832
  13. Sebastian Michaelsen abandoned the change 09/29/26, 13:00