92360[WIP][FEATURE] Add event to modify max upload file size
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 3
Review log 913
-
Sebastian Michaelsen uploaded patch set 1 01/16/26, 23:22
-
Sebastian Michaelsen uploaded patch set 2 01/16/26, 23:23
-
Sebastian Michaelsen uploaded patch set 3 01/16/26, 23:24
-
core-ci voted on patch set 1 V +1 01/16/26, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93647
-
core-ci voted on patch set 2 V +1 01/16/26, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93648
-
core-ci voted on patch set 3 V +1 01/16/26, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93649
-
Garvin Hicking commented on patch set 3 01/17/26, 00:32
ModifyMaxUploadFileSize.php:23UnresolvedPlease use `ModifyMaxUploadFileSizeEvent` for this to adhere to the PSR-14 event naming scheme of the core. Also, please make it a final class.ResourceStorage.php:993UnresolvedI think this needs to throw exception in case events set a higher upload limit than PHP allows. It must be ensured that only a lower limit is set.Feature-108660-AddPSR-14EventModifyMaxUploadFileSize.rst:6Unresolvedcopy pasta leftoverFeature-108660-AddPSR-14EventModifyMaxUploadFileSize.rst:26Unresolvedcopy pasta leftovers :) -
Sebastian Michaelsen uploaded patch set 4
V +101/19/26, 07:46 -
core-ci voted on patch set 4 V +1 01/19/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93752
-
Georg Ringer commented on patch set 4 01/19/26, 08:13
just as an idea: could we move the event somewhere else and call it a more general name - so it could be used to skip files either e.g. because of size or also because, maybe its content is problematic - checked by some 3rd party tool, copyright issues or whatever? what do you think? -
Sebastian Michaelsen marked it work in progress 03/22/26, 12:18
-
Sebastian Michaelsen commented on patch set 4 09/29/26, 13:00
Thank you for your reviews, I'll abandon this change and issue in favor of #110832 -
Sebastian Michaelsen abandoned the change 09/29/26, 13:00
Unresolved