92364[FEATURE] Add visibility control for form elements in Form Editor
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
Issues 1
Files 37
- Build/Sources/Sass/form.scss4+25 −2
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+6 −1
- Build/Sources/TypeScript/form/backend/form-editor/tree-component.ts+3 −1
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108663-AdjustVisibilityOfFormElementsInFormEditor.rstnew+38 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+7 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Converters/AddRenderableVisibilityConverter.phpnew+48 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+24 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml2+5 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/ContentElement.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/CountrySelect.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+6 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Fieldset.yaml+5 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/FileUpload.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/GridColumn.yaml+5 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/GridRow.yaml+5 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Hidden.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/ImageUpload.yaml+5 −0
Show 17 more files
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiSelect.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SingleSelect.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/StaticText.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml+5 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf3+3 −0
- typo3/sysext/form/Resources/Public/Css/form.css+5 −2
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/tree-component.js+1 −1
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+161 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+173 −0
Review log 2435
Show 610 earlier messages
-
Josua Vogel uploaded patch set 1 01/17/26, 13:49
-
Josua Vogel updated the commit message in patch set 2 01/17/26, 13:50
-
core-ci voted on patch set 1 V -1 01/17/26, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93678
-
core-ci voted on patch set 2 V -1 01/17/26, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93679
-
Josua Vogel uploaded patch set 3
V -101/17/26, 14:10 -
core-ci voted on patch set 3 V +1 01/17/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93680
-
Josua Vogel uploaded patch set 4
V +101/18/26, 15:14 -
core-ci voted on patch set 4 V +1 01/18/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93720
-
Benjamin Kott commented on patch set 4 01/18/26, 18:49
form.scss:860we need to use the same colors here as above, the css should be scoped and not use directly the surface colors -
Josua Vogel uploaded patch set 5 01/19/26, 07:36
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
-
Josua Vogel uploaded patch set 6
V +101/19/26, 07:38 -
core-ci voted on patch set 5 V +1 01/19/26, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93749
-
core-ci voted on patch set 6 V +1 01/19/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93750
-
Josua Vogel commented on patch set 6 01/19/26, 08:14
form.scss:653ReplyDoneform.scss:860ReplyDone -
Sven Liebert voted on patch set 6 CR +1 V +1 01/19/26, 08:52
-
Benjamin Kott commented on patch set 6 CR -1 01/19/26, 11:27
Checkbox.yaml:97i think we should always provide a default value for enabled true; this would make setting it here obsolete since elements should always start enabled and can be disabled in the editor. we can consider respecting false here - but not sure tbh. it just feels like an internal control field no editor should actually care about. i also see it added above, and i understand why this is happening, still it feels like even that is unnessesary and it should be just a feature of the framework. -
Josua Vogel uploaded patch set 7
CR +1V +101/19/26, 13:39 -
Josua Vogel uploaded patch set 8 01/19/26, 13:41
-
Josua Vogel commented on patch set 8 01/19/26, 13:41
Checkbox.yaml:97ReplyDone -
core-ci voted on patch set 7 V +1 01/19/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93776
-
core-ci voted on patch set 8 V +1 01/19/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93777
-
Benjamin Kott uploaded patch set 9
V +101/19/26, 15:48 -
Benjamin Kott uploaded patch set 10 01/19/26, 15:53
-
Benjamin Kott voted on patch set 10 CR +1 V +1 01/19/26, 15:54
-
core-ci voted on patch set 9 V -1 01/19/26, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93784
-
core-ci voted on patch set 10 V +1 01/19/26, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93786
-
Oli Bartsch commented on patch set 10 CR -1 V +1 01/19/26, 16:30
Works, let's just change the label please.Database.xlf:772```suggestion <source>Field visible</source> ``` See ``` <trans-unit id="formEditor.elements.FormElement.editor.requiredValidator.label"> <source>Field required</source> </trans-unit> ``` -
Josua Vogel commented on patch set 11
CR +1V +101/19/26, 16:42Published edit on patch set 10. -
Benjamin Kott commented on patch set 11 CR +1 V +1 01/19/26, 16:43
Database.xlf:772ReplyDone -
Benjamin Kott commented on patch set 11 01/19/26, 16:44
Reply
Done -
Oli Bartsch voted on patch set 11 CR +1 V +1 01/19/26, 16:46
-
Benjamin Kott voted on patch set 11 CR +2 V +2 01/19/26, 16:48
-
Benjamin Kott merged patch set 12 01/19/26, 16:48
-
core-ci voted on patch set 11 V +1 01/19/26, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93789
-
Josua Vogel commented on patch set 12 01/19/26, 16:54
Database.xlf:772ReplyFix applied.
form.scss:653