Review main Merged

92364[FEATURE] Add visibility control for form elements in Form Editor

Josua Vogel CR +2 V +2 Hard +616 −14 updated 01/19/26, 16:54

Commit message

Introduce a new visibility option in the Form Editor that allows
editors to show or hide form elements directly through the
user interface.

The visibility setting can be configured in the element's
configuration panel and is stored in the form definition. This
eliminates the need to manually edit YAML files for basic
visibility control.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1

Issues 1

Files 37

Show 17 more files

Review log 2435

Show 610 earlier messages
  1. Josua Vogel uploaded patch set 1 01/17/26, 13:49

  2. Josua Vogel updated the commit message in patch set 2 01/17/26, 13:50

  3. core-ci voted on patch set 1 V -1 01/17/26, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93678

  4. core-ci voted on patch set 2 V -1 01/17/26, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93679

  5. Josua Vogel uploaded patch set 3 V -1 01/17/26, 14:10

  6. core-ci voted on patch set 3 V +1 01/17/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93680

  7. Josua Vogel uploaded patch set 4 V +1 01/18/26, 15:14

  8. core-ci voted on patch set 4 V +1 01/18/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93720

  9. Benjamin Kott commented on patch set 4 01/18/26, 18:49

    form.scss:653

    we need to use the same colors here as above, the css should be scoped and not use directly the surface colors

    form.scss:860

    we need to use the same colors here as above, the css should be scoped and not use directly the surface colors
  10. Josua Vogel uploaded patch set 5 01/19/26, 07:36

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  1. Josua Vogel uploaded patch set 6 V +1 01/19/26, 07:38

  2. core-ci voted on patch set 5 V +1 01/19/26, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93749

  3. core-ci voted on patch set 6 V +1 01/19/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93750

  4. Josua Vogel commented on patch set 6 01/19/26, 08:14

    form.scss:653 Reply

    Done

    form.scss:860 Reply

    Done
  5. Sven Liebert voted on patch set 6 CR +1 V +1 01/19/26, 08:52

  6. Benjamin Kott commented on patch set 6 CR -1 01/19/26, 11:27

    Checkbox.yaml:97

    i think we should always provide a default value for enabled true; this would make setting it here obsolete since elements should always start enabled and can be disabled in the editor. we can consider respecting false here - but not sure tbh. it just feels like an internal control field no editor should actually care about. i also see it added above, and i understand why this is happening, still it feels like even that is unnessesary and it should be just a feature of the framework.
  7. Josua Vogel uploaded patch set 7 CR +1 V +1 01/19/26, 13:39

  8. Josua Vogel uploaded patch set 8 01/19/26, 13:41

  9. Josua Vogel commented on patch set 8 01/19/26, 13:41

    Checkbox.yaml:97 Reply

    Done
  10. core-ci voted on patch set 7 V +1 01/19/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93776

  11. core-ci voted on patch set 8 V +1 01/19/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93777

  12. Benjamin Kott uploaded patch set 9 V +1 01/19/26, 15:48

  13. Benjamin Kott uploaded patch set 10 01/19/26, 15:53

  14. Benjamin Kott voted on patch set 10 CR +1 V +1 01/19/26, 15:54

  15. core-ci voted on patch set 9 V -1 01/19/26, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93784

  16. core-ci voted on patch set 10 V +1 01/19/26, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93786

  17. Oli Bartsch commented on patch set 10 CR -1 V +1 01/19/26, 16:30

    Works, let's just change the label please.

    Database.xlf:772

    ```suggestion <source>Field visible</source> ``` See ``` <trans-unit id="formEditor.elements.FormElement.editor.requiredValidator.label"> <source>Field required</source> </trans-unit> ```
  18. Josua Vogel commented on patch set 11 CR +1 V +1 01/19/26, 16:42

    Published edit on patch set 10.
  19. Benjamin Kott commented on patch set 11 CR +1 V +1 01/19/26, 16:43

    Database.xlf:772 Reply

    Done
  20. Benjamin Kott commented on patch set 11 01/19/26, 16:44

    Reply

    Done
  21. Oli Bartsch voted on patch set 11 CR +1 V +1 01/19/26, 16:46

  22. Benjamin Kott voted on patch set 11 CR +2 V +2 01/19/26, 16:48

  23. Benjamin Kott merged patch set 12 01/19/26, 16:48

  24. core-ci voted on patch set 11 V +1 01/19/26, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93789

  25. Josua Vogel commented on patch set 12 01/19/26, 16:54

    Database.xlf:772 Reply

    Fix applied.