Review main Merged

92365[BUGFIX] Respect xml:space attribute in XLIFF parser

Benni Mack CR +2 V +2 Hard +275 −10 updated 01/21/26, 11:11

Commit message

The XLIFF parser now properly handles whitespace according
to the XML specification by respecting the xml:space attribute.

Without xml:space="preserve" (default):
- Multiple consecutive whitespace characters are collapsed into a single space
- Leading and trailing whitespace is trimmed

With xml:space="preserve":
- Whitespace is kept exactly as written in the XLIFF file

This fixes issues where multi-line translation strings in XLIFF
files would contain unintended line breaks and indentation from
the XML formatting.

Both XLIFF 1.2 and XLIFF 2.x formats are supported.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1317

  1. Benni Mack uploaded patch set 1 01/17/26, 19:35

  2. core-ci voted on patch set 1 V +1 01/17/26, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93685

  3. Benni Mack marked it ready for review 01/19/26, 11:47

  4. Georg Ringer voted on patch set 1 CR +1 V +1 01/19/26, 11:55

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/19/26, 12:56

  6. Benni Mack uploaded patch set 2 CR +1 V +1 01/19/26, 14:22

  7. core-ci voted on patch set 2 V +1 01/19/26, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93779

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/19/26, 15:36

  9. Benni Mack commented on patch set 3 CR +1 V +1 01/20/26, 15:36

    Published edit on patch set 2.
  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/20/26, 15:39

  11. core-ci voted on patch set 3 V -1 01/20/26, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93872

  12. Simon Schaufelberger voted on patch set 3 CR 0 V 0 01/20/26, 21:44

  13. Benni Mack rebased onto patch set 4 V -1 01/21/26, 07:09

  14. core-ci voted on patch set 4 V +1 01/21/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93917

  15. Simon Schaufelberger voted on patch set 4 CR +1 V +1 01/21/26, 09:32

  16. Georg Ringer voted on patch set 4 CR +2 V +2 01/21/26, 11:11

  17. Georg Ringer merged patch set 5 01/21/26, 11:11