Review main Merged

92371[TASK] Support columnsOverrides in all DataHandler operations

Benni Mack CR +2 V +2 Hard +303 −51 updated 01/22/26, 13:15

Commit message

DataHandler now respects TCA columnsOverrides configuration during
copy, move, delete, localization, and other operations. Previously,
this was only done during checkValue(), and many DataHandler methods
accessed field configuration directly from  the main TCA schema,
bypassing type-specific columnsOverrides.

This allows developers to reuse database columns across different
record types by configuring them differently via columnsOverrides,
reducing unnecessary column creation and improving database design.

A small fix related to a sloppy hook is now considered in
CreateSiteConfiguration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1623

  1. Benni Mack uploaded patch set 1 01/18/26, 09:56

  2. core-ci voted on patch set 1 V -1 01/18/26, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93715

  3. Benni Mack uploaded patch set 2 V -1 01/20/26, 16:20

  4. Benni Mack marked it ready for review 01/20/26, 16:20

  5. core-ci voted on patch set 2 V +1 01/20/26, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93878

  6. Oli Bartsch commented on patch set 2 01/21/26, 11:25

    DataHandler.php:8058

    Let's use `BackendUtility::getTCAtypeValue();` here to properly resolve foreign field name etc.

    DataHandler.php:8059

    Maybe check for not empty here.

    DataHandler.php:8424

    Maybe we can add a method for this, sth. like `getFieldForRecordContext()`? This piece of code is now duplicated at a lot of places.

    ColumnsOverridesTest.php:62

    I can't see where this test does actually test columnsOverrides
  7. Benni Mack uploaded patch set 3 V +1 01/21/26, 15:40

  8. core-ci voted on patch set 3 V -1 01/21/26, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93960

  9. Benni Mack uploaded patch set 4 V -1 01/21/26, 21:26

  10. core-ci voted on patch set 4 V -1 01/21/26, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93980

  11. Benni Mack uploaded patch set 5 V -1 01/21/26, 21:47

  12. core-ci voted on patch set 5 V -1 01/21/26, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93982

  13. Benni Mack marked it ready for review 01/21/26, 21:55

  14. Benni Mack rebased onto patch set 6 V -1 01/22/26, 08:24

  15. Benni Mack commented on patch set 6 01/22/26, 08:24

    DataHandler.php:8058 Reply

    Done

    DataHandler.php:8059 Reply

    Done

    DataHandler.php:8424 Reply

    Done

    ColumnsOverridesTest.php:62 Reply

    Done
  16. core-ci voted on patch set 6 V +1 01/22/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94017

  17. Oli Bartsch uploaded patch set 7 V +1 01/22/26, 10:50

  18. Oli Bartsch voted on patch set 7 CR +1 V +1 01/22/26, 10:52

  19. core-ci voted on patch set 7 V +1 01/22/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94029

  20. Stefan Bürk commented on patch set 7 01/22/26, 12:27

    Reviewing ...
  21. Stefan Bürk commented on patch set 7 CR +1 V +1 01/22/26, 13:07

    Reply

    Done
  22. Benni Mack voted on patch set 7 CR +2 V +2 01/22/26, 13:15

  23. Benni Mack merged patch set 8 01/22/26, 13:15