92371[TASK] Support columnsOverrides in all DataHandler operations
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php6+85 −48
- typo3/sysext/core/Classes/Hooks/CreateSiteConfiguration.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataSet/ColumnsOverridesPages.csvnew+3 −0
- typo3/sysext/core/Tests/Functional/DataHandling/ColumnsOverridesTest.php2new+206 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+3 −0
Review log 1623
-
Benni Mack uploaded patch set 1 01/18/26, 09:56
-
core-ci voted on patch set 1 V -1 01/18/26, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93715
-
Benni Mack uploaded patch set 2
V -101/20/26, 16:20 -
Benni Mack marked it ready for review 01/20/26, 16:20
-
core-ci voted on patch set 2 V +1 01/20/26, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93878
-
Oli Bartsch commented on patch set 2 01/21/26, 11:25
DataHandler.php:8059Maybe check for not empty here.DataHandler.php:8424Maybe we can add a method for this, sth. like `getFieldForRecordContext()`? This piece of code is now duplicated at a lot of places.ColumnsOverridesTest.php:62I can't see where this test does actually test columnsOverrides -
Benni Mack uploaded patch set 3
V +101/21/26, 15:40 -
core-ci voted on patch set 3 V -1 01/21/26, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93960
-
Benni Mack uploaded patch set 4
V -101/21/26, 21:26 -
core-ci voted on patch set 4 V -1 01/21/26, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93980
-
Benni Mack uploaded patch set 5
V -101/21/26, 21:47 -
core-ci voted on patch set 5 V -1 01/21/26, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93982
-
Benni Mack marked it ready for review 01/21/26, 21:55
-
Benni Mack rebased onto patch set 6
V -101/22/26, 08:24 -
Benni Mack commented on patch set 6 01/22/26, 08:24
DataHandler.php:8058ReplyDoneDataHandler.php:8059ReplyDoneDataHandler.php:8424ReplyDoneColumnsOverridesTest.php:62ReplyDone -
core-ci voted on patch set 6 V +1 01/22/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94017
-
Oli Bartsch uploaded patch set 7
V +101/22/26, 10:50 -
Oli Bartsch voted on patch set 7 CR +1 V +1 01/22/26, 10:52
-
core-ci voted on patch set 7 V +1 01/22/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94029
-
Stefan Bürk commented on patch set 7 01/22/26, 12:27
Reviewing ... -
Stefan Bürk commented on patch set 7 CR +1 V +1 01/22/26, 13:07
Reply
Done -
Benni Mack voted on patch set 7 CR +2 V +2 01/22/26, 13:15
-
Benni Mack merged patch set 8 01/22/26, 13:15
DataHandler.php:8058