Review main Merged

92372[TASK] Use native types in Extbase Arguments class

Torben Hansen CR +2 V +2 Normal +16 −54 updated 01/19/26, 08:14

Commit message

This change introduces native PHP types for properties,
function arguments and return types in the class
`TYPO3\CMS\Extbase\Mvc\Controller\Arguments`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Torben Hansen uploaded patch set 1 01/18/26, 13:21

  2. core-ci voted on patch set 1 V +1 01/18/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93716

  3. Oliver Klee updated the commit message in patch set 2 V +1 01/18/26, 14:42

  4. Oliver Klee commented on patch set 2 V +1 01/18/26, 14:44

    Arguments.php:177

    Can we add a return type here? ```suggestion public function __call(string $methodName, array $arguments): void ```
  5. core-ci voted on patch set 2 V +1 01/18/26, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93718

  6. Torben Hansen uploaded patch set 3 V +1 01/18/26, 17:35

  7. Torben Hansen commented on patch set 2 01/18/26, 17:35

    Arguments.php:177 Reply

    Done
  8. core-ci voted on patch set 3 V +1 01/18/26, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93727

  9. Oliver Klee voted on patch set 3 CR +1 V +1 01/18/26, 22:46

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/18/26, 23:20

  11. Georg Ringer voted on patch set 3 CR +2 V +2 01/19/26, 08:14

  12. Georg Ringer merged patch set 4 01/19/26, 08:14