Review main Merged

92374[TASK] Streamline position of custom error message in form editor

Josua Vogel CR +2 V +2 Easy +10 −23 updated 01/19/26, 06:53

Commit message

The date range validator now positions the custom error message options
as the last field, matching the behavior of all other validators.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Sven Liebert +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Sven Liebert +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Josua Vogel uploaded patch set 1 01/18/26, 17:12

  2. Josua Vogel commented on patch set 1 01/18/26, 17:15

    In my opinion, this is not a breaking change. While we do change the key of the element (its position), which could potentially cause minor issues, we also introduce new keys with new features that might already be in use by custom configurations or extensions. This is a common practice in the development process and does not constitute a breaking change, as the functionality itself remains unchanged - only the order of fields in the form editor UI is adjusted for consistency.
  3. core-ci voted on patch set 1 V +1 01/18/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93723

  4. Benjamin Kott voted on patch set 1 CR +1 V +1 01/18/26, 18:42

  5. Sven Liebert voted on patch set 1 CR +1 V +1 01/18/26, 22:38

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/18/26, 22:39

  7. Benjamin Kott voted on patch set 1 CR +2 V +2 01/19/26, 06:53

  8. Benjamin Kott merged patch set 2 01/19/26, 06:53