92385[TASK] Avoid json_decode/json_encode in Menu Processors
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+114 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+4 −2
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php3+56 −287
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+40 −291
Review log 1216
-
Benni Mack uploaded patch set 1 01/19/26, 13:25
-
core-ci voted on patch set 1 V -1 01/19/26, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93775
-
Benni Mack uploaded patch set 2
V -101/19/26, 13:55 -
Benni Mack marked it ready for review 01/19/26, 13:56
-
core-ci voted on patch set 2 V +1 01/19/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93778
-
Nikita Hovratov commented on patch set 2 01/19/26, 14:16
-
Georg Ringer commented on patch set 2 CR +1 V +1 01/19/26, 20:43
LanguageMenuProcessor.php:206Replybut also the lines below are then invalid, like "$languageObject->getLocale()->getName();" does not work. it would leave only the keys active,current,available but with which benefit? -
Nikita Hovratov uploaded patch set 3
CR +1V +101/19/26, 21:50 -
core-ci voted on patch set 3 V +1 01/19/26, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93800
-
Nikita Hovratov commented on patch set 3 01/19/26, 22:13
LanguageMenuProcessor.php:206ReplyDone, see patchset 3. -
Nikita Hovratov updated the commit message in patch set 4
V +101/19/26, 23:16 -
core-ci voted on patch set 4 V +1 01/19/26, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93803
-
Georg Ringer voted on patch set 4 CR +1 V +1 01/20/26, 06:31
-
Nikita Hovratov voted on patch set 4 CR +1 V +1 01/20/26, 08:19
-
Benni Mack voted on patch set 4 CR +2 V +2 01/20/26, 11:33
-
Benni Mack merged patch set 5 01/20/26, 11:33
LanguageMenuProcessor.php:206