Review main Abandoned

92392[BUGFIX] Only set predefinedDefaults if visibility editor exists

Josua Vogel CR 0 V -1 Easy +11 −2 updated 01/20/26, 05:54

Commit message

The FormEditorController previously set the predefined default value
for `renderingOptions.enabled` unconditionally if editors were present
in the element definition. This caused issues when no editor for
`renderingOptions.enabled` existed.

The logic now checks if an editor with the propertyPath
`renderingOptions.enabled` is actually configured before setting
the predefined default. This ensures that default values are only
set when the corresponding editor is available to modify them.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 23

  1. Josua Vogel uploaded patch set 1 01/19/26, 19:29

  2. core-ci voted on patch set 1 V -1 01/19/26, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93796

  3. Josua Vogel abandoned the change 01/20/26, 05:54