92394[BUGFIX] Use correct tests for checking sorting
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Georg Ringer uploaded patch set 1 01/19/26, 20:56
-
Georg Ringer commented on patch set 1 01/19/26, 20:56
This change is ready for review. -
core-ci voted on patch set 1 V +1 01/19/26, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93798
-
Oliver Klee commented on patch set 1 01/20/26, 14:39
FileListTest.php:52I find this unnecessarily complex to read. Instead, I'd like to propose using an array with literal strings for `$expected`.FileListTest.php:57Please let's harden the fn by adding a type and return type declaration.FileListTest.php:59This mixes the "execute" and the "verify" steps. I propose having the call separate, then a blank line, and then the stringification and the assert.FileListTest.php:60We need to use `assertSame` to also check the order of the elements.FileListTest.php:92Ditto everything. :-) -
Georg Ringer uploaded patch set 2
V +101/20/26, 20:05 -
Georg Ringer commented on patch set 2 01/20/26, 20:05
FileListTest.php:52Replywould like to keep that to avoid the repeating complicated file names when it comes to special charsFileListTest.php:57ReplyDoneFileListTest.php:59ReplyDoneFileListTest.php:60ReplyDoneFileListTest.php:92ReplyDone -
core-ci voted on patch set 2 V +1 01/20/26, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93888
-
Oliver Klee uploaded patch set 3
V +101/21/26, 11:33 -
Oliver Klee commented on patch set 2 01/21/26, 11:33
FileListTest.php:52ReplyAcknowledged -
Oliver Klee voted on patch set 3 CR +1 V +1 01/21/26, 11:33
-
core-ci voted on patch set 3 V +1 01/21/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93938
-
Benni Mack voted on patch set 3 CR +2 V +2 01/21/26, 11:50
-
Benni Mack merged patch set 4 01/21/26, 11:50