Review main Merged

92395[BUGFIX] Remove automatic renderingOptions.enabled handling

Benjamin Kott CR +2 V +2 Hard +29 −415 updated 01/20/26, 08:09

Commit message

The FormEditorController previously set `renderingOptions.enabled: true`
as a predefined default for all elements with editors. Additionally, the
AddRenderableVisibilityConverter added this property to all form elements
when loading them into the editor. This caused HMAC validation errors for
elements that do not have a visibility editor configured.

Since `AbstractRenderable::isEnabled()` already defaults to `true` when
the property is not set, and the JavaScript visibility check uses
`=== false` which treats undefined as enabled, this automatic handling
was unnecessary.

This patch removes the predefined default injection in
getFormEditorDefinitions() and removes the AddRenderableVisibilityConverter
along with its invocation. The CheckboxEditor is updated to display as
checked when renderingOptions.enabled is undefined, matching the PHP
default behavior.

An example showing how integrators can extend their own form elements
with the visibility feature has been added to the changelog entry.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 68

  1. Benjamin Kott uploaded patch set 1 01/19/26, 21:13

  2. core-ci voted on patch set 1 V +1 01/19/26, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93799

  3. Josua Vogel uploaded patch set 2 V +1 01/20/26, 07:14

  4. Josua Vogel voted on patch set 2 CR +1 V +1 01/20/26, 07:15

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 01/20/26, 07:20

  6. core-ci voted on patch set 2 V +1 01/20/26, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93836

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 01/20/26, 08:09

  8. Benjamin Kott merged patch set 3 01/20/26, 08:09