Review main Merged

92396[FEATURE] Add site edit and site settings to context menu of root page

Benjamin Kott CR +2 V +2 Normal +190 −1 updated 01/20/26, 08:24

Commit message

Admin users can now access "Edit Site" and "Edit Site Settings" directly
from the context menu when right-clicking on a site root page.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Garvin Hicking +1

Issues 1

Files 5

Review log 1115

  1. Benjamin Kott uploaded patch set 1 01/19/26, 22:14

  2. Benjamin Kott uploaded patch set 2 01/19/26, 22:17

  3. core-ci voted on patch set 1 V -1 01/19/26, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93801

  4. core-ci voted on patch set 2 V -1 01/19/26, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93802

  5. Benjamin Kott uploaded patch set 3 V -1 01/20/26, 07:04

  6. core-ci voted on patch set 3 V +1 01/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93833

  7. Josua Vogel voted on patch set 3 CR +1 V +1 01/20/26, 07:26

  8. Garvin Hicking commented on patch set 3 CR +1 V +1 01/20/26, 07:43

    superhandy
  9. Benjamin Franzke commented on patch set 3 CR -1 01/20/26, 07:47

    SiteSettingsProvider.php:62

    The array `+` syntax is hard to grasp, Please tell claudia to use https://www.php.net/manual/en/function.array-splice.php ``` $items = array_splice($items, $position, 0, $localItems); ``` Or at least array unfolding: ``` $items = [ ...array_slice($items, 0, $position + 1, true), ...$localItems, ...array_slice($items, $position + 1, null, true), ]; ```

    SiteSettingsProvider.php:94

    Please tell claudia to learn DI. See typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php line 151

    SiteSettingsProvider.php:106

    Please tell claudia to learn DI. See typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php line 151
  10. Benjamin Franzke uploaded patch set 4 CR +1 V +1 01/20/26, 08:17

  11. Benjamin Franzke commented on patch set 4 01/20/26, 08:17

    SiteSettingsProvider.php:62 Reply

    Done

    SiteSettingsProvider.php:94 Reply

    Done

    SiteSettingsProvider.php:106 Reply

    Done
  12. Garvin Hicking commented on patch set 4 CR +1 V +1 01/20/26, 08:19

    Eww, I'm sorry I did not spot the needed changes. I should have.
  13. Oli Bartsch voted on patch set 4 CR +2 V +2 01/20/26, 08:22

  14. Oli Bartsch merged patch set 5 01/20/26, 08:22

  15. core-ci voted on patch set 4 V +1 01/20/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93848