92396[FEATURE] Add site edit and site settings to context menu of root page
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Garvin Hicking +1
Issues 1
Files 5
- Build/Sources/TypeScript/backend/context-menu-actions.ts+14 −0
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/SiteSettingsProvider.php6new+138 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108694-ContextMenuItemsToEditSiteConfigurationForPages.rstnew+31 −0
Review log 1115
-
Benjamin Kott uploaded patch set 1 01/19/26, 22:14
-
Benjamin Kott uploaded patch set 2 01/19/26, 22:17
-
core-ci voted on patch set 1 V -1 01/19/26, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93801
-
core-ci voted on patch set 2 V -1 01/19/26, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93802
-
Benjamin Kott uploaded patch set 3
V -101/20/26, 07:04 -
core-ci voted on patch set 3 V +1 01/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93833
-
Josua Vogel voted on patch set 3 CR +1 V +1 01/20/26, 07:26
-
Garvin Hicking commented on patch set 3 CR +1 V +1 01/20/26, 07:43
superhandy -
Benjamin Franzke commented on patch set 3 CR -1 01/20/26, 07:47
SiteSettingsProvider.php:62The array `+` syntax is hard to grasp, Please tell claudia to use https://www.php.net/manual/en/function.array-splice.php ``` $items = array_splice($items, $position, 0, $localItems); ``` Or at least array unfolding: ``` $items = [ ...array_slice($items, 0, $position + 1, true), ...$localItems, ...array_slice($items, $position + 1, null, true), ]; ```SiteSettingsProvider.php:94Please tell claudia to learn DI. See typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php line 151SiteSettingsProvider.php:106Please tell claudia to learn DI. See typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php line 151 -
Benjamin Franzke uploaded patch set 4
CR +1V +101/20/26, 08:17 -
Benjamin Franzke commented on patch set 4 01/20/26, 08:17
SiteSettingsProvider.php:62ReplyDoneSiteSettingsProvider.php:94ReplyDoneSiteSettingsProvider.php:106ReplyDone -
Garvin Hicking commented on patch set 4 CR +1 V +1 01/20/26, 08:19
Eww, I'm sorry I did not spot the needed changes. I should have. -
Oli Bartsch voted on patch set 4 CR +2 V +2 01/20/26, 08:22
-
Oli Bartsch merged patch set 5 01/20/26, 08:22
-
core-ci voted on patch set 4 V +1 01/20/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93848