Review main Merged

92412[TASK] Update PHPStan to 2.1.34

Garvin Hicking CR +2 V +2 Normal +29 −33 updated 01/20/26, 14:59

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.34 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

- Adjusted @param-out effects
- Removed unneeded empty() check
- Replaced wording of already ignored baseline
- Removed superfluous check for language aware schema

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2129

Show 34 earlier messages
  1. Garvin Hicking uploaded patch set 1 01/20/26, 06:24

  2. core-ci voted on patch set 1 V +1 01/20/26, 06:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93828

  3. Andreas Kienast uploaded patch set 2 V +1 01/20/26, 06:55

  4. Andreas Kienast updated the commit message in patch set 3 01/20/26, 06:55

  1. Elias Häußler commented on patch set 1 01/20/26, 06:58

    DataHandlerPermissionGuardHook.php:39

    I'm not very happy with having `null` as the only type here, because this is IMHO not technically correct (it *may* be null, but it could also just stay `array<string, mixed>`). Since I don't know what has changed in this area with the latest PHPStan release and don't have time to investigate this further, I'd say we can safely remove the `@param-out` annotation, because it serves no real purpose here. WDYT?
  2. Andreas Kienast commented on patch set 3 01/20/26, 07:05

    DataHandlerPermissionGuardHook.php:39 Reply

    I'd also opt to drop this. `$incomingFieldArray` is set to null, but not in every case, thus the phpdoc isn't correct.
  3. core-ci voted on patch set 2 V +1 01/20/26, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93831

  4. core-ci voted on patch set 3 V +1 01/20/26, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93832

  5. Andreas Kienast uploaded patch set 4 V +1 01/20/26, 07:10

  6. Garvin Hicking commented on patch set 4 01/20/26, 07:15

    DataHandlerPermissionGuardHook.php:39 Reply

    I would not add it to the baseline though, maybe just remove it altogether?!
  7. core-ci voted on patch set 4 V +1 01/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93834

  8. Elias Häußler commented on patch set 4 01/20/26, 07:32

    DataHandlerPermissionGuardHook.php:39 Reply

    on it
  9. Garvin Hicking uploaded patch set 5 V +1 01/20/26, 07:36

  10. core-ci voted on patch set 5 V +1 01/20/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93843

  11. Elias Häußler uploaded patch set 6 V +1 01/20/26, 07:47

  12. Elias Häußler commented on patch set 6 01/20/26, 07:48

    DataHandlerPermissionGuardHook.php:39 Reply

    Done
  13. Elias Häußler voted on patch set 6 CR +1 V +1 01/20/26, 07:49

  14. core-ci voted on patch set 6 V +1 01/20/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93844

  15. Garvin Hicking updated the commit message in patch set 7 CR +1 V +1 01/20/26, 08:04

  16. core-ci voted on patch set 7 V +1 01/20/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93845

  17. Elias Häußler voted on patch set 7 CR +1 V +1 01/20/26, 08:15

  18. Oliver Klee voted on patch set 7 CR +1 V +1 01/20/26, 08:43

  19. Garvin Hicking uploaded patch set 8 CR +1 V +1 01/20/26, 13:44

  20. Simon Schaufelberger voted on patch set 8 CR +1 V +1 01/20/26, 13:47

  21. Oliver Hader voted on patch set 8 CR +1 V +1 01/20/26, 13:54

  22. core-ci voted on patch set 8 V +1 01/20/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93864

  23. Oliver Klee voted on patch set 8 CR +1 V +1 01/20/26, 14:17

  24. Garvin Hicking voted on patch set 8 CR +2 V +2 01/20/26, 14:59

  25. Garvin Hicking merged patch set 9 01/20/26, 14:59