92412[TASK] Update PHPStan to 2.1.34
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Oliver Hader +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Oliver Hader +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
Review log 2129
Show 34 earlier messages
-
Garvin Hicking uploaded patch set 1 01/20/26, 06:24
-
core-ci voted on patch set 1 V +1 01/20/26, 06:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93828
-
Andreas Kienast uploaded patch set 2
V +101/20/26, 06:55 -
Andreas Kienast updated the commit message in patch set 3 01/20/26, 06:55
-
Elias Häußler commented on patch set 1 01/20/26, 06:58
-
Andreas Kienast commented on patch set 3 01/20/26, 07:05
DataHandlerPermissionGuardHook.php:39ReplyI'd also opt to drop this. `$incomingFieldArray` is set to null, but not in every case, thus the phpdoc isn't correct. -
core-ci voted on patch set 2 V +1 01/20/26, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93831
-
core-ci voted on patch set 3 V +1 01/20/26, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93832
-
Andreas Kienast uploaded patch set 4
V +101/20/26, 07:10 -
Garvin Hicking commented on patch set 4 01/20/26, 07:15
DataHandlerPermissionGuardHook.php:39ReplyI would not add it to the baseline though, maybe just remove it altogether?! -
core-ci voted on patch set 4 V +1 01/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93834
-
Elias Häußler commented on patch set 4 01/20/26, 07:32
DataHandlerPermissionGuardHook.php:39Replyon it -
Garvin Hicking uploaded patch set 5
V +101/20/26, 07:36 -
core-ci voted on patch set 5 V +1 01/20/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93843
-
Elias Häußler uploaded patch set 6
V +101/20/26, 07:47 -
Elias Häußler commented on patch set 6 01/20/26, 07:48
DataHandlerPermissionGuardHook.php:39ReplyDone -
Elias Häußler voted on patch set 6 CR +1 V +1 01/20/26, 07:49
-
core-ci voted on patch set 6 V +1 01/20/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93844
-
Garvin Hicking updated the commit message in patch set 7
CR +1V +101/20/26, 08:04 -
core-ci voted on patch set 7 V +1 01/20/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93845
-
Elias Häußler voted on patch set 7 CR +1 V +1 01/20/26, 08:15
-
Oliver Klee voted on patch set 7 CR +1 V +1 01/20/26, 08:43
-
Garvin Hicking uploaded patch set 8
CR +1V +101/20/26, 13:44 -
Simon Schaufelberger voted on patch set 8 CR +1 V +1 01/20/26, 13:47
-
Oliver Hader voted on patch set 8 CR +1 V +1 01/20/26, 13:54
-
core-ci voted on patch set 8 V +1 01/20/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93864
-
Oliver Klee voted on patch set 8 CR +1 V +1 01/20/26, 14:17
-
Garvin Hicking voted on patch set 8 CR +2 V +2 01/20/26, 14:59
-
Garvin Hicking merged patch set 9 01/20/26, 14:59
DataHandlerPermissionGuardHook.php:39