Review main Merged

92428[BUGFIX] Respect top-level form variants when parsing form definitions

Elias Häußler CR +2 V +2 Easy +3 −0 updated 01/22/26, 10:13

Commit message

Persisted form definitions may contain configured variants at top-level
to customize the overall form rendering based on a given condition. With
the recent modifications in #108390 targeting form persistence handling,
the new `FormData` was introduced without native support for configured
`variants`. This is now fixed and the form persistence layer is capable
of form variants again.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1113

  1. Elias Häußler uploaded patch set 1 01/20/26, 15:48

  2. core-ci voted on patch set 1 V +1 01/20/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93874

  3. Oliver Hader voted on patch set 1 CR +1 01/20/26, 16:12

  4. Josua Vogel commented on patch set 1 CR +1 V +1 01/20/26, 16:15

    Thx!
  5. Guido Schmechel voted on patch set 1 CR +1 V +1 01/20/26, 16:21

  6. Garvin Hicking voted on patch set 1 CR +1 V +1 01/20/26, 17:00

  7. Elias Häußler updated the commit message in patch set 2 CR +1 V +1 01/20/26, 18:25

  8. Josua Vogel voted on patch set 2 CR +1 V +1 01/20/26, 18:33

  9. core-ci voted on patch set 2 V +1 01/20/26, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93881

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 01/20/26, 19:00

  11. Sven Liebert voted on patch set 2 CR +1 V +1 01/20/26, 21:14

  12. Garvin Hicking voted on patch set 2 CR +2 V +2 01/22/26, 10:13

  13. Garvin Hicking merged patch set 3 01/22/26, 10:13