Review main Merged

92431[BUGFIX] Prevent "danger" class for empty redirect integrity

Christian Bülter CR +2 V +2 Easy +1 −1 updated 07/29/26, 16:12

Commit message

In the redirects module, all redirects
which don't have an integrity status
value are shown with a "danger" class
(red background).

This is misleading because there may
be cases when the integrity status is
empty and the redirects are OK, e.g.,
the instance has been updated from version 12.

Therefore, redirects with no integrity
status should not be marked with "danger".
This patch fixes that.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2025

  1. Christian Bülter uploaded patch set 1 01/20/26, 17:42

  2. core-ci voted on patch set 1 V +1 01/20/26, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93880

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 01/20/26, 17:57

  4. Josua Vogel voted on patch set 1 CR +1 V +1 01/20/26, 18:18

  5. Josef Glatz voted on patch set 1 CR +1 V +1 01/20/26, 18:38

  6. Guido Schmechel commented on patch set 1 CR +1 V +1 01/20/26, 19:12

    This definitely helps with the output. It would also affect systems that are upgrading and start with empty ‘integrity_status’ fields. It also affects v13.
  7. Guido Schmechel commented on patch set 1 01/20/26, 19:20

    Reply

    In https://review.typo3.org/c/Packages/TYPO3.CMS/+/77285, the new field is defined with default in the TCA, and therefore also in the database. So it would be good to know why this empty case exists? But this new condition does no harm either way.
  8. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 01/20/26, 19:26

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 01/20/26, 19:26

  10. core-ci voted on patch set 2 V +1 01/20/26, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93887

  11. Garvin Hicking commented on patch set 2 CR 0 V 0 01/20/26, 19:52

    The integrity status being empty could also be related to https://review.typo3.org/c/Packages/TYPO3.CMS/+/92307 - the field should actually not be empty. Let's try to find the root cause of this, so that this bugfix will not just fix the symptom. Once we figure this out, a "danger" status for redirects without any status might actually be helpful? @guido@ayacoo.de is doing some detective work (thanks) 😊
  12. Guido Schmechel voted on patch set 2 CR +1 V +1 01/20/26, 21:25

  13. Josef Glatz voted on patch set 2 CR +1 V +1 01/22/26, 07:36

  14. Christian Bülter rebased onto patch set 3 CR +1 V +1 02/03/26, 14:30

  15. core-ci voted on patch set 3 V +1 02/03/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94918

  16. Benni Mack updated the commit message in patch set 4 V +1 04/22/26, 07:15

  17. core-ci voted on patch set 4 V -1 04/22/26, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100852

  18. Markus Klein commented on patch set 4 CR -1 06/11/26, 19:33

    The bug is that this is missing a backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/92534
  19. Markus Klein commented on patch set 4 CR 0 06/11/26, 19:37

    Reply

    I meant v13 is missing a backport of the aforementioned.
  20. Benni Mack rebased onto patch set 5 V -1 07/29/26, 13:29

  21. core-ci voted on patch set 5 V +1 07/29/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105607

  22. Benni Mack commented on patch set 5 07/29/26, 13:47

    Reply

    well, the reason is simple (and it happened to me in most projects): we upgrade from v12 to v13 with populated redirects. the DB analyzer creates the new DB field with a default value from TcaSchemaBuilder for new rows, but for existing ones it stays empty. This already happened to 1000s of installations. Either we do it like the patch proposes or create an upgrade wizard fixing all of these installations and have it clean (incl. backporting).
  23. Garvin Hicking commented on patch set 5 CR +1 V +1 07/29/26, 16:01

    Reply

    Acknowledged
  24. Benni Mack voted on patch set 5 CR +2 V +2 07/29/26, 16:12

  25. Benni Mack merged patch set 6 07/29/26, 16:12