Review main Merged

92432[TASK] Update PHPStan to 2.1.38

Garvin Hicking CR +2 V +2 Easy +10 −15 updated 02/01/26, 17:56

Commit message

Bugfix versions of PHPStan were released as a follow-up
to address the `@param-out` issue (among others) that
came up in #108697 (2.1.35, 2.1.36, 2.1.37, 2.1.38).

With this, `@param-out` can be introduced again.

Type hints are adapted to prevent a new baseline entry.

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.38 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Markus Klein +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 3342

Show 1217 earlier messages
  1. Garvin Hicking uploaded patch set 1 01/20/26, 18:57

  2. Garvin Hicking commented on patch set 1 CR -1 01/20/26, 18:57

    Since the bugfix addresses no other baseline entries for us, let's wait a few days for possible further regressions caused in PHPStan 2.1.34 (many, many changes).
  3. core-ci voted on patch set 1 V +1 01/20/26, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93883

  4. Garvin Hicking uploaded patch set 2 CR -1 V +1 01/21/26, 14:21

  5. core-ci voted on patch set 2 V +1 01/21/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93954

  6. Oliver Klee updated the commit message in patch set 3 V +1 01/21/26, 14:51

  7. Oliver Klee voted on patch set 3 CR +1 V +1 01/21/26, 14:51

  8. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 01/21/26, 14:55

  9. Garvin Hicking commented on patch set 4 CR -1 01/21/26, 14:55

    still holding out for more PHPStan releases this week
  10. core-ci voted on patch set 4 V +1 01/21/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93957

  11. Oliver Klee voted on patch set 4 CR +1 V +1 01/21/26, 15:07

  12. core-ci voted on patch set 3 V +1 01/21/26, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93956

  13. Garvin Hicking uploaded patch set 5 CR +1 V +1 01/24/26, 09:14

  14. Garvin Hicking commented on patch set 5 CR -1 01/24/26, 09:15

    still holding out for more PHPStan releases next week
  15. core-ci voted on patch set 5 V +1 01/24/26, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94240

  16. Oliver Klee voted on patch set 5 CR +1 V +1 01/24/26, 09:26

  17. Garvin Hicking uploaded patch set 6 CR +1 V +1 01/30/26, 20:06

  1. Oliver Klee voted on patch set 6 CR +1 01/30/26, 20:10

  2. core-ci voted on patch set 6 V +1 01/30/26, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94703

  3. Markus Klein commented on patch set 6 01/30/26, 20:50

    > $dbList->setOverrideUrlParameters(array_merge($this->getUrlParameters([]), ['mode' => 'db', 'expandPage' => $selectedPage]), $request); expandPage is an int!
  4. Markus Klein commented on patch set 6 01/30/26, 20:52

    The type-annotation of setOverrideUrlParameters is wrong, it can be a nested array too
  5. Garvin Hicking commented on patch set 6 01/31/26, 12:44

    Reply

    Want to push over the patch?
  6. Markus Klein uploaded patch set 7 CR +1 V +1 02/01/26, 09:29

  7. Markus Klein commented on patch set 7 02/01/26, 09:30

    Reply

    did so, but > [ERROR] An internal error occurred. Baseline could not be generated. whatever the reason is, I did not find out yet.
  8. core-ci voted on patch set 7 V -1 02/01/26, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94754

  9. Markus Klein uploaded patch set 8 V -1 02/01/26, 09:58

  10. core-ci voted on patch set 8 V +1 02/01/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94756

  11. Oliver Klee voted on patch set 8 CR +1 V +1 02/01/26, 10:15

  12. Oliver Klee voted on patch set 8 CR 0 02/01/26, 10:16

  13. Oliver Klee voted on patch set 8 CR +1 02/01/26, 13:24

  14. Oliver Klee commented on patch set 8 CR 0 02/01/26, 13:25

    Who or what is Bueller? And should these questions stay in the commit message?
  15. Oliver Klee commented on patch set 8 02/01/26, 13:38

    Also, this change now _removes_ a baseline entry instead of adding one. So this line looks outdated to me.
  16. Garvin Hicking updated the commit message in patch set 9 V +1 02/01/26, 13:40

  17. Garvin Hicking commented on patch set 9 02/01/26, 13:41

    Reply

    This seems resolved?

    Reply

    Done

    Reply

    Done
  18. Garvin Hicking commented on patch set 9 02/01/26, 13:41

    Reply

    Done
  19. Oliver Klee voted on patch set 9 CR +1 V +1 02/01/26, 13:44

  20. core-ci voted on patch set 9 V +1 02/01/26, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94764

  21. Stefan Bürk commented on patch set 9 CR +1 V +1 02/01/26, 15:01

    Reply

    Done
  22. Markus Klein commented on patch set 9 02/01/26, 15:01

    Reply

    I resolved this manually in the baseline file. the command did not work locally for me on the Mac. Will try again tomorrow on WSL and Fedora
  23. Markus Klein voted on patch set 9 CR +1 V +1 02/01/26, 15:03

  24. Garvin Hicking commented on patch set 9 CR +2 V +2 02/01/26, 17:56

    thanks all!
  25. Garvin Hicking merged patch set 10 02/01/26, 17:56