Review main Merged

92433[BUGFIX] Improve page title cropping in backend modules

Josef Glatz CR +2 V +2 Normal +54 −39 updated 01/22/26, 08:37

Commit message

This patch adopts the styling and the fluid to render page titles in
the table like in the Records backend module. Page titles are not
cropped to a maximum length of 20 anymore and text is visually cropped
only with CSS ellipsis.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2231

Show 56 earlier messages
  1. Josef Glatz uploaded patch set 1 01/20/26, 19:13

  2. Josef Glatz commented on patch set 1 01/20/26, 19:20

    The final CSS needs to be done. However the functionality is like in the records module (former list module)

    Index.fluid.html:49

    There are two steps: This is step one: Patch set 1 has all necessary adopts to have the same behaviour like in the record backend module. Since I was always wrong with the TYPO3 Core Backend CSS, I pushed a work-in-progress patch here with the necessary existing classes and an inline style tag, where someone with a perspective and better frontend knowledge might be able to adjust it. The table in the Record module differs from the permission record table. We have also a div within the cell here. And this also contains the icon aligned with CSS Flex. This means I have used the existing CSS logic as much as possible so that it behaves the same in the browser for now. Whether we need to rewrite the entire table of the Permission module is still open. Perhaps this is also a question for the BE frontend guys?

    Index.fluid.html:50

    There are two steps: This is step two: remove the fluid VH to crop the text
  3. Josef Glatz commented on patch set 1 01/20/26, 19:20

    This change is ready for review.
  4. core-ci voted on patch set 1 V +1 01/20/26, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93884

  5. Josef Glatz updated the commit message in patch set 2 V +1 01/20/26, 19:22

  6. Josef Glatz updated the commit message in patch set 3 01/20/26, 19:25

  1. core-ci voted on patch set 2 V +1 01/20/26, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93885

  2. core-ci voted on patch set 3 V +1 01/20/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93886

  3. Josef Glatz updated the commit message in patch set 4 V +1 01/21/26, 03:35

  4. Josef Glatz updated the commit message in patch set 5 01/21/26, 03:38

  5. Josef Glatz updated the commit message in patch set 6 01/21/26, 03:43

  6. core-ci voted on patch set 4 V +1 01/21/26, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93895

  7. core-ci voted on patch set 5 V +1 01/21/26, 03:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93896

  8. core-ci voted on patch set 6 V +1 01/21/26, 03:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93897

  9. Josef Glatz updated the commit message in patch set 7 V +1 01/21/26, 08:06

  10. core-ci voted on patch set 7 V +1 01/21/26, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93919

  11. Oli Bartsch commented on patch set 7 01/21/26, 09:50

    Index.fluid.html:49

    Please let's avoid inline styles.
  12. Josef Glatz commented on patch set 7 01/21/26, 10:16

    Index.fluid.html:49 Reply

    Please see my inital unresolved comment above! I need feedback from a backend frontend guy
  13. Benjamin Kott uploaded patch set 8 V +1 01/21/26, 13:38

  14. Benjamin Kott commented on patch set 8 01/21/26, 13:39

    Index.fluid.html:49 Reply

    Done

    Index.fluid.html:49 Reply

    Done
  15. Benjamin Kott voted on patch set 8 CR +1 V +1 01/21/26, 13:39

  16. core-ci voted on patch set 8 V +1 01/21/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93950

  17. Josef Glatz commented on patch set 8 V +1 01/21/26, 14:28

    Thank You for your help @benjamin.kott@outlook.com
  18. Josef Glatz voted on patch set 8 CR +1 01/21/26, 14:29

  19. Oli Bartsch commented on patch set 8 01/21/26, 17:30

    RecordList, where this was reported for still defines "nowrap" class next to "col-responsive". should be fixed as well I think. Recycler should be adjusted as well. ("col-path" in table with "itemsInRecycler" id). "col-title col-responsive" used in the Media module is also not behaving correctly. TypoScript module also "pre-crops" page titles.

    TranslationStatusController.php:211

    The localizations should be fixed accordingly.
  20. Benjamin Kott uploaded patch set 9 CR +1 V +1 01/22/26, 07:22

  21. Benjamin Kott commented on patch set 9 01/22/26, 07:22

    Reply

    was reported for the permissions module see attached screen. would keep it like that for now, i just quickly scanned to other treeline-container usages and some similar.

    PageInformationController.php:485 Reply

    Done

    TranslationStatusController.php:211 Reply

    Done
  22. core-ci voted on patch set 9 V +1 01/22/26, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94011

  23. Benjamin Kott voted on patch set 9 CR +1 V +1 01/22/26, 07:33

  24. Oli Bartsch voted on patch set 9 CR +2 V +2 01/22/26, 08:37

  25. Oli Bartsch merged patch set 10 01/22/26, 08:37