92433[BUGFIX] Improve page title cropping in backend modules
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/component/_table.scss+4 −1
- Build/Sources/Sass/module/_access.scss+0 −4
- Build/Sources/Sass/typo3/_element_tree.scss+7 −0
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −3
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.fluid.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Show.fluid.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.fluid.html6+3 −3
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.fluid.html+3 −7
- typo3/sysext/info/Classes/Controller/PageInformationController.php2+18 −3
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php2+13 −16
Review log 2231
Show 56 earlier messages
-
Josef Glatz uploaded patch set 1 01/20/26, 19:13
-
Josef Glatz commented on patch set 1 01/20/26, 19:20
The final CSS needs to be done. However the functionality is like in the records module (former list module)Index.fluid.html:49There are two steps: This is step one: Patch set 1 has all necessary adopts to have the same behaviour like in the record backend module. Since I was always wrong with the TYPO3 Core Backend CSS, I pushed a work-in-progress patch here with the necessary existing classes and an inline style tag, where someone with a perspective and better frontend knowledge might be able to adjust it. The table in the Record module differs from the permission record table. We have also a div within the cell here. And this also contains the icon aligned with CSS Flex. This means I have used the existing CSS logic as much as possible so that it behaves the same in the browser for now. Whether we need to rewrite the entire table of the Permission module is still open. Perhaps this is also a question for the BE frontend guys?Index.fluid.html:50There are two steps: This is step two: remove the fluid VH to crop the text -
Josef Glatz commented on patch set 1 01/20/26, 19:20
This change is ready for review. -
core-ci voted on patch set 1 V +1 01/20/26, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93884
-
Josef Glatz updated the commit message in patch set 2
V +101/20/26, 19:22 -
Josef Glatz updated the commit message in patch set 3 01/20/26, 19:25
-
core-ci voted on patch set 2 V +1 01/20/26, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93885
-
core-ci voted on patch set 3 V +1 01/20/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93886
-
Josef Glatz updated the commit message in patch set 4
V +101/21/26, 03:35 -
Josef Glatz updated the commit message in patch set 5 01/21/26, 03:38
-
Josef Glatz updated the commit message in patch set 6 01/21/26, 03:43
-
core-ci voted on patch set 4 V +1 01/21/26, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93895
-
core-ci voted on patch set 5 V +1 01/21/26, 03:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93896
-
core-ci voted on patch set 6 V +1 01/21/26, 03:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93897
-
Josef Glatz updated the commit message in patch set 7
V +101/21/26, 08:06 -
core-ci voted on patch set 7 V +1 01/21/26, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93919
-
Oli Bartsch commented on patch set 7 01/21/26, 09:50
Index.fluid.html:49Please let's avoid inline styles. -
Josef Glatz commented on patch set 7 01/21/26, 10:16
Index.fluid.html:49ReplyPlease see my inital unresolved comment above! I need feedback from a backend frontend guy -
Benjamin Kott uploaded patch set 8
V +101/21/26, 13:38 -
Benjamin Kott commented on patch set 8 01/21/26, 13:39
Index.fluid.html:49ReplyDoneIndex.fluid.html:49ReplyDone -
Benjamin Kott voted on patch set 8 CR +1 V +1 01/21/26, 13:39
-
core-ci voted on patch set 8 V +1 01/21/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93950
-
Josef Glatz commented on patch set 8 V +1 01/21/26, 14:28
Thank You for your help @benjamin.kott@outlook.com -
Josef Glatz voted on patch set 8 CR +1 01/21/26, 14:29
-
Oli Bartsch commented on patch set 8 01/21/26, 17:30
RecordList, where this was reported for still defines "nowrap" class next to "col-responsive". should be fixed as well I think. Recycler should be adjusted as well. ("col-path" in table with "itemsInRecycler" id). "col-title col-responsive" used in the Media module is also not behaving correctly. TypoScript module also "pre-crops" page titles.PageInformationController.php:485Named parameters are not allowed here. https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.htmlTranslationStatusController.php:211The localizations should be fixed accordingly. -
Benjamin Kott uploaded patch set 9
CR +1V +101/22/26, 07:22 -
Benjamin Kott commented on patch set 9 01/22/26, 07:22
Reply
was reported for the permissions module see attached screen. would keep it like that for now, i just quickly scanned to other treeline-container usages and some similar.PageInformationController.php:485ReplyDoneTranslationStatusController.php:211ReplyDone -
core-ci voted on patch set 9 V +1 01/22/26, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94011
-
Benjamin Kott voted on patch set 9 CR +1 V +1 01/22/26, 07:33
-
Oli Bartsch voted on patch set 9 CR +2 V +2 01/22/26, 08:37
-
Oli Bartsch merged patch set 10 01/22/26, 08:37