Review main Merged

92434[TASK] Replace Bootstrap dropdown with Popover API

Benjamin Kott CR +2 V +2 Hard +437 −197 updated 01/26/26, 08:49

Commit message

Removes the Bootstrap dropdown JavaScript component in favor of the
native Popover API. Adds keyboard navigation for accessibility
following the WAI-ARIA menu button pattern. The legacy
data-bs-toggle="dropdown" syntax remains supported through an
automatic conversion layer.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 3053

Show 1828 earlier messages
  1. Benjamin Kott uploaded patch set 1 01/20/26, 21:26

  2. Benjamin Kott updated the commit message in patch set 2 01/20/26, 21:27

  3. core-ci voted on patch set 2 V +1 01/20/26, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93890

  4. core-ci voted on patch set 1 V +1 01/20/26, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93889

  5. Benjamin Kott uploaded patch set 3 V +1 01/22/26, 14:46

  6. core-ci voted on patch set 3 V -1 01/22/26, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94041

  7. Benjamin Franzke uploaded patch set 4 V -1 01/22/26, 17:59

  8. Benjamin Kott uploaded patch set 5 01/22/26, 18:04

  9. Benjamin Franzke uploaded patch set 6 01/22/26, 18:13

  10. Benjamin Kott uploaded patch set 7 01/22/26, 18:27

  11. core-ci voted on patch set 6 V -1 01/22/26, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94081

  12. core-ci voted on patch set 4 V -1 01/22/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94076

  13. core-ci voted on patch set 7 V -1 01/22/26, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94082

  14. core-ci voted on patch set 5 V -1 01/22/26, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94078

  15. Benjamin Kott uploaded patch set 8 V -1 01/22/26, 19:17

  16. Benjamin Franzke uploaded patch set 9 01/22/26, 19:23

  17. Benjamin Franzke uploaded patch set 10 01/22/26, 19:24

  18. core-ci voted on patch set 8 V -1 01/22/26, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94087

  19. Benjamin Franzke rebased onto patch set 11 01/22/26, 19:28

  20. core-ci voted on patch set 11 V -1 01/22/26, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94092

  21. Benjamin Kott uploaded patch set 12 V -1 01/23/26, 08:17

  22. core-ci voted on patch set 12 V -1 01/23/26, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94140

  23. Benjamin Kott uploaded patch set 13 V -1 01/23/26, 11:40

  24. Benjamin Kott uploaded patch set 14 01/23/26, 11:54

  25. Benjamin Kott uploaded patch set 15 01/23/26, 12:13

  26. Benjamin Franzke commented on patch set 15 01/23/26, 12:17

    dropdown.ts:64

    ```suggestion document.querySelectorAll<HTMLElement>('.dropdown-menu[popover]:popover-open').forEach(menu => menu.hidePopover()); ```
  27. Benjamin Kott uploaded patch set 16 01/23/26, 12:30

  28. Benjamin Kott commented on patch set 16 01/23/26, 12:31

    dropdown.ts:64 Reply

    Done
  1. core-ci voted on patch set 13 V -1 01/23/26, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94157

  2. core-ci voted on patch set 16 V -1 01/23/26, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94169

  3. core-ci voted on patch set 14 V -1 01/23/26, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94162

  4. core-ci voted on patch set 15 V -1 01/23/26, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94166

  5. Benjamin Kott uploaded patch set 17 V -1 01/23/26, 13:43

  6. core-ci voted on patch set 17 V -1 01/23/26, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94172

  7. Benjamin Kott uploaded patch set 18 V -1 01/23/26, 14:03

  8. core-ci voted on patch set 18 V -1 01/23/26, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94174

  9. Benjamin Kott uploaded patch set 19 V -1 01/23/26, 16:46

  10. core-ci voted on patch set 19 V +1 01/23/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94189

  11. Benjamin Kott rebased onto patch set 20 V +1 01/24/26, 01:04

  12. core-ci voted on patch set 20 V +1 01/24/26, 01:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94218

  13. Benjamin Kott uploaded patch set 21 V +1 01/24/26, 09:39

  14. Benjamin Kott uploaded patch set 22 01/24/26, 09:42

  15. core-ci voted on patch set 21 V +1 01/24/26, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94241

  16. Benjamin Kott uploaded patch set 23 01/24/26, 09:49

  17. core-ci voted on patch set 22 V -1 01/24/26, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94242

  18. Benjamin Kott uploaded patch set 24 01/24/26, 09:53

  19. core-ci voted on patch set 23 V -1 01/24/26, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94243

  20. core-ci voted on patch set 24 V -1 01/24/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94244

  21. Benjamin Kott uploaded patch set 25 V -1 01/24/26, 10:35

  22. core-ci voted on patch set 25 V +1 01/24/26, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94245

  23. Benni Mack commented on patch set 25 CR +1 V +1 01/24/26, 20:29

    works just fine, really good with the conversion layer as I used this in quite some extensions.
  24. Benjamin Franzke voted on patch set 25 CR +2 V +2 01/26/26, 08:49

  25. Benjamin Franzke merged patch set 26 01/26/26, 08:49