Review main Merged

92435[BUGFIX] Add title from image properties only when not set via argument

Richard Krikler CR +2 V +2 Easy +10 −4 updated 02/06/26, 16:42

Commit message

When trying to display an image without an alt-attribute
`alt=""` can be set as a ViewHelper attribute.
On the other hand, trying to display an image without a title-attribute
is not possible with setting `title=""`.
It will result in trying to fallback to the title stored
within the image properties.

Only trying to set the title-attribute from the image-properties when
the additional ViewHelper attribute is not set solves this issue.

As the HTML `title` attribute is not explicitly necessary,
it can be fully omitted.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Peter Kraume +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Peter Kraume +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Richard Krikler uploaded patch set 1 01/21/26, 07:07

  2. core-ci voted on patch set 1 V +1 01/21/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93916

  3. Benni Mack commented on patch set 1 CR -1 01/21/26, 10:28

    Which versions should be used? main or also 13.4?
  4. Richard Krikler rebased onto patch set 2 CR -1 V +1 01/21/26, 10:33

  5. core-ci voted on patch set 2 V +1 01/21/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93932

  6. Richard Krikler commented on patch set 2 02/01/26, 19:05

    Reply

    done - sry (main & 13.4)
  7. Georg Ringer voted on patch set 2 CR +1 V +1 02/05/26, 15:52

  8. Garvin Hicking commented on patch set 2 02/06/26, 09:11

    Please shorten the commit subject to <= 72 chars
  9. Richard Krikler updated the commit message in patch set 3 CR +1 V +1 02/06/26, 09:23

  10. Richard Krikler commented on patch set 3 02/06/26, 09:24

    Reply

    done
  11. Richard Krikler commented on patch set 3 02/06/26, 09:24

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 02/06/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95254

  13. Peter Kraume voted on patch set 3 CR +1 V +1 02/06/26, 10:10

  14. Garvin Hicking voted on patch set 3 CR +1 V +1 02/06/26, 16:41

  15. Georg Ringer voted on patch set 3 CR +2 V +2 02/06/26, 16:42

  16. Georg Ringer merged patch set 4 02/06/26, 16:42