Review main Merged

92438[TASK] Exclude unused bootstrap JavaScript components from bundling

Benjamin Franzke CR +2 V +2 Normal +100 −14 updated 01/23/26, 17:26

Commit message

We only use a subset of bootstrap modules (e.g. `<dialog>` instead of
bootstrap modal) and more features (like dropdowns) can be replaced by
modern browser API, which is why this starts excluding certain bootstrap
JavaScript components, by explicitly listing selected components, that
we actually use.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1727

Show 2 earlier messages
  1. Benjamin Franzke uploaded patch set 1 01/21/26, 10:30

  2. Benjamin Franzke uploaded patch set 2 01/21/26, 10:34

  1. core-ci voted on patch set 1 V +1 01/21/26, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93931

  2. Benjamin Franzke uploaded patch set 3 01/21/26, 10:41

  3. Benjamin Franzke uploaded patch set 4 01/21/26, 10:45

  4. core-ci voted on patch set 2 V +1 01/21/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93933

  5. core-ci voted on patch set 3 V +1 01/21/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93934

  6. core-ci voted on patch set 4 V -1 01/21/26, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93935

  7. Benjamin Franzke uploaded patch set 5 V -1 01/22/26, 17:52

  8. core-ci voted on patch set 5 V -1 01/22/26, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94074

  9. Benjamin Franzke uploaded patch set 6 V -1 01/22/26, 18:13

  10. core-ci voted on patch set 6 V -1 01/22/26, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94080

  11. Benjamin Franzke uploaded patch set 7 V -1 01/22/26, 18:59

  12. core-ci voted on patch set 7 V +1 01/22/26, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94084

  13. Benjamin Franzke uploaded patch set 8 V +1 01/22/26, 19:14

  14. Benjamin Franzke uploaded patch set 9 01/22/26, 19:23

  15. core-ci voted on patch set 8 V +1 01/22/26, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94086

  16. Benjamin Franzke rebased onto patch set 10 01/22/26, 19:28

  17. core-ci voted on patch set 10 V +1 01/22/26, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94091

  18. Benjamin Franzke uploaded patch set 11 V +1 01/22/26, 20:06

  19. core-ci voted on patch set 11 V +1 01/22/26, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94095

  20. Benjamin Kott voted on patch set 11 CR +1 V +1 01/23/26, 08:12

  21. Oli Bartsch voted on patch set 11 CR +1 V +1 01/23/26, 16:49

  22. Simon Schaufelberger commented on patch set 11 01/23/26, 17:09

    Will this have any influence on other backend modules that use these components or not? If so, I would expect an important rest
  23. Benjamin Kott commented on patch set 11 01/23/26, 17:24

    Reply

    - we only support the modal via the modal api - alerts are handled via the notification api - we disabled deprecated tooltips in v12 - and we never supported the others and do not even ship the css in parts - dropdowns will also be replaced and polyfilled i think we can remove it without notice, as it never existed and was more or less merged in parts because we only cared about the css, but was never api
  24. Benjamin Kott voted on patch set 11 CR +2 V +2 01/23/26, 17:25

  25. Benjamin Kott merged patch set 12 01/23/26, 17:26