Review 13.4 Merged

92443[BUGFIX] Use sprite references in SvgSpriteIconProvider inline output

Benjamin Franzke CR +2 V +2 Hard +252 −9 updated 01/21/26, 15:18

Commit message

Sprite-based icons were expected to provide a standalone SVG
file (additionally to the sprite) for rendering via inline markup,
causing SVGs contents to be transferred instead of using references
to a cacheable sprite.

To improve the output of inline rendered icons, we now allow
to render sprite renferences using `<use xlink:href>` references,
when no explicit `source` option for standalone rendering is provided.

The core provided icon sprite is adapted to make use of this
improvement.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Benjamin Franzke commented on patch set 1 01/21/26, 13:55

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Imaging/IconProvider/SvgSpriteIconProvider.php * typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgSpriteIconProviderTest.php
  2. core-ci voted on patch set 1 V -1 01/21/26, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93952

  3. Benjamin Franzke uploaded patch set 2 V -1 01/21/26, 15:02

  4. Benjamin Franzke uploaded patch set 3 CR +2 V +2 01/21/26, 15:02

  5. core-ci voted on patch set 3 V +1 01/21/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93959

  6. Benjamin Franzke merged patch set 4 01/21/26, 15:18