Review main Merged

92445[BUGFIX] Migrate linkvalidator results for pages.url

Oli Bartsch CR +2 V +2 Normal +173 −3 updated 01/22/26, 14:20

Commit message

The "url" field of pages with doktype "link" was replaced
by the "link" field in #17406. However, linkvalidator still
stores this information for broken links found in the system.

This now non-existing pages+url combination led to an
exception in the link check module. This is prevented by
properly checking for field existence. Additionally, an
upgrade wizard is added to migrate existing records.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1518

  1. Oli Bartsch uploaded patch set 1 01/21/26, 18:31

  2. core-ci voted on patch set 1 V +1 01/21/26, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93969

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/21/26, 18:53

  4. Benni Mack commented on patch set 1 01/21/26, 18:54

    Shouldn't this upgrade wizard be moved to EXT:linkvalidator?
  5. Stefan Bürk commented on patch set 1 01/21/26, 23:17

    Reply

    Would also say that moved to `EXT:linkvalidator`.
  6. Oli Bartsch uploaded patch set 2 CR +1 V +1 01/22/26, 08:31

  7. Oli Bartsch commented on patch set 2 01/22/26, 08:31

    Reply

    Acknowledged
  8. core-ci voted on patch set 2 V +1 01/22/26, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94018

  9. Benni Mack commented on patch set 2 01/22/26, 09:03

    LinkValidatorFieldMigration.php:66

    $tableSchema->hasColumn is not needed, as all linkvalidator tables (database compare) have to be executed before this upgrade wizard.
  10. Benni Mack uploaded patch set 3 V +1 01/22/26, 09:32

  11. Benni Mack marked it ready for review 01/22/26, 09:33

  12. Benni Mack commented on patch set 3 01/22/26, 09:33

    LinkValidatorFieldMigration.php:66 Reply

    Done
  13. Benni Mack voted on patch set 3 CR +1 V +1 01/22/26, 09:34

  14. core-ci voted on patch set 3 V +1 01/22/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94025

  15. Oli Bartsch commented on patch set 3 01/22/26, 09:56

    LinkValidatorFieldMigration.php:66 Reply

    Thanks!
  16. Stefan Bürk voted on patch set 3 CR +1 V +1 01/22/26, 13:58

  17. Oli Bartsch voted on patch set 3 CR +2 V +2 01/22/26, 14:20

  18. Oli Bartsch merged patch set 4 01/22/26, 14:20