92448[FEATURE] Add QR code button for frontend preview URIs
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 29
- Build/Sources/Sass/element/typo3-qrcode.scss+19 −0
- Build/Sources/TypeScript/backend/element/qrcode-element.ts+59 −1
- Build/Sources/TypeScript/backend/element/qrcode-modal-button.ts3renamed+16 −12
- Build/Sources/TypeScript/backend/copy-to-clipboard.ts+25 −10
- Build/Sources/TypeScript/form/backend/form-editor/component/property-grid-editor.ts+0 −1
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+22 −0
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+42 −1
- typo3/sysext/backend/Classes/Controller/RecordListController.php+17 −0
- typo3/sysext/backend/Classes/Template/Components/Event/ModifyPreviewUrlForQrCodeEvent.phpnew+59 −0
- typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php+51 −0
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+14 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+6 −0
- typo3/sysext/backend/Resources/Private/Language/qrcode.xlf+9 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.fluid.html+11 −0
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.fluid.html+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/qrcode-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/qrcode-modal-button.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/copy-to-clipboard.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108720-QRCodeButtonForFrontendPreviewURLs.rstnew+40 −0
Show 9 more files
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/component/property-grid-editor.js+1 −1
- typo3/sysext/redirects/Resources/Private/Templates/QrCode/Overview.fluid.html+1 −1
- typo3/sysext/redirects/Resources/Public/JavaScript/element/qrcode-modal-button.jsdeleted+0 −13
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+10 −0
- typo3/sysext/viewpage/Resources/Private/Templates/Show.fluid.html+1 −0
- typo3/sysext/workspaces/Classes/EventListener/ModifyPreviewUrlForQrCodeListener.php9new+63 −0
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+10 −0
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+1 −1
Review log 2837
Show 812 earlier messages
-
Oli Bartsch uploaded patch set 1 01/21/26, 22:45
-
core-ci voted on patch set 1 V +1 01/21/26, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93983
-
Simon Schaufelberger commented on patch set 1 01/21/26, 23:11
Great feature! One thing I noticed is an inconsistency between the Layout and the Records view. In the Layout view the button is a combined button while on the Records view it is a standalone button. Can we make this consistent? -
Oli Bartsch uploaded patch set 2
V +101/22/26, 07:34 -
Oli Bartsch commented on patch set 2 01/22/26, 07:35
Reply
Sure. Thanks for the pointer. -
core-ci voted on patch set 2 V +1 01/22/26, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94012
-
Oli Bartsch uploaded patch set 3
V +101/22/26, 15:10 -
core-ci voted on patch set 3 V +1 01/22/26, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94047
-
Oli Bartsch uploaded patch set 4
V +101/22/26, 16:35 -
core-ci voted on patch set 4 V -1 01/22/26, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94064
-
Stefan Bürk commented on patch set 4 01/22/26, 16:56
ModifyPreviewUrlForQrCodeListener.php:50```suggestion if ($previewUrl !== '') { ```ModifyPreviewUrlForQrCodeListener.php:53Do we really want to catch exception so broad without logging it ? I'd suggest that we should only catch `UnableToLinkToPageException` and leave other errors/exceptions to end in a stack trace. What do you think ? -
Georg Ringer voted on patch set 4 CR +1 V +1 01/22/26, 20:16
-
Simon Schaufelberger uploaded patch set 5
CR +1V +101/22/26, 21:25 -
Simon Schaufelberger commented on patch set 4 01/22/26, 21:25
ModifyPreviewUrlForQrCodeListener.php:50ReplyDone -
core-ci voted on patch set 5 V +1 01/22/26, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94100
-
Simon Schaufelberger uploaded patch set 6
V +101/22/26, 21:35 -
Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/22/26, 21:36
-
Simon Schaufelberger uploaded patch set 7
CR +1V +101/22/26, 21:37 -
Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/22/26, 21:39
-
core-ci voted on patch set 7 V +1 01/22/26, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94102
-
Oli Bartsch uploaded patch set 8
CR +1V +101/22/26, 21:50 -
Oli Bartsch commented on patch set 8 01/22/26, 21:50
ModifyPreviewUrlForQrCodeListener.php:53ReplyDone -
Simon Schaufelberger commented on patch set 8 01/22/26, 21:56
qrcode-modal-button.ts:90no console.log please in production codeModifyPreviewUrlForQrCodeListener.php:41I just moved this line on the class level to be "best practice" -
core-ci voted on patch set 8 V -1 01/22/26, 21:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94104
-
Stefan Bürk commented on patch set 8 01/23/26, 00:15
ModifyPreviewUrlForQrCodeListener.php:41ReplyNot getting this. Best practice defined by whom ? It's absolutly valid to have AsEventListener on the method or on the class level (if only one method exists. (And we have no rule for that). -
Simon Schaufelberger commented on patch set 8 01/23/26, 00:47
ModifyPreviewUrlForQrCodeListener.php:41Replyhttps://docs.typo3.org/permalink/t3coreapi:eventdispatchereventlistenerclass -> when using __invoke it is used on the class level while it should be only used on a method level when a "real method" is used. We should be a good example and don't always do things different ways (because we can) but be consistent! Inconsistent ways are way harder to migrate in the long term (a general rule). -
Oli Bartsch commented on patch set 8 01/23/26, 07:37
ModifyPreviewUrlForQrCodeListener.php:41ReplyI cant find your quote in the docs. It actually says > The PHP attribute can also be used on a method level. The above example can also be written as: and shows an example of exactly this scenario with `__invoke()`. We currently use the attribute 80% on method level. I'm not willing to change this now across the code base for no reason. -
Simon Schaufelberger commented on patch set 8 01/23/26, 10:59
ModifyPreviewUrlForQrCodeListener.php:41Replyyou are right, most of the times the annotation is actually on the method level. The docs first say: put it on the class level and then later on, that you can also put it on the method level. -
Oli Bartsch uploaded patch set 9
V -101/23/26, 11:38 -
Oli Bartsch uploaded patch set 10 01/23/26, 11:46
-
core-ci voted on patch set 9 V -1 01/23/26, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94156
-
core-ci voted on patch set 10 V +1 01/23/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94159
-
Simon Schaufelberger commented on patch set 10 CR +1 V +1 01/23/26, 12:38
qrcode-modal-button.ts:90ReplyDone -
Garvin Hicking voted on patch set 10 CR +1 V +1 01/23/26, 15:45
-
Stefan Bürk voted on patch set 10 CR +1 V +1 01/23/26, 16:12
-
Oli Bartsch commented on patch set 10 CR +2 V +2 01/23/26, 16:13
qrcode-modal-button.ts:90ReplyDone -
Oli Bartsch merged patch set 11 01/23/26, 16:13