Review main Abandoned

92452[BUGFIX] Cast request parameters to expected type in `DownloadController`

Stefan Bürk CR 0 V 0 Easy +2 −2 updated 01/22/26, 11:00

Commit message

@todo Check/Investigate reported JS error in the linked issue

`DownloadController` of `EXT:extensionmanager` recieves
request parameters for the version range and pass them to
method `findByVersionRangeAndExtensionKeyOrderedByVersion()`,
which expectes integer typed parameters.

This change casts recieved request arguments to integer
to have the matching variable type in place to mitigate
following error:

  ExtensionRepository::findByVersionRangeAndExtensionKeyOrderedByVersion():
  Argument #2 ($lowestVersion) must be of type int,
  string given

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 23

  1. Stefan Bürk uploaded patch set 1 01/22/26, 08:15

  2. core-ci voted on patch set 1 V +1 01/22/26, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94016

  3. Stefan Bürk abandoned the change 01/22/26, 11:00