Review main Merged

92458[BUGFIX] Cast propertyName to string

Oli Bartsch CR +2 V +2 Easy +1 −0 updated 01/22/26, 10:52

Commit message

With #108666, strict types were added to Extbase
argument mapping. However, property names from
the "__trustedProperties" field may be converted
to integers.

For example, using `f:form.submit` will be added
as `0:"1"` to the trusted properties string,
which now causes a TypeError due to native typing.

Examples are the "Extension Upload" or "Install
with Conflicts" forms in Extension Manager.

This is fixed by applying proper type casting.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 01/22/26, 10:09

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 01/22/26, 10:14

  3. core-ci voted on patch set 1 V +1 01/22/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94028

  4. Torben Hansen voted on patch set 1 CR +1 V +1 01/22/26, 10:18

  5. Josua Vogel voted on patch set 1 CR +1 V +1 01/22/26, 10:19

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 01/22/26, 10:52

  7. Oli Bartsch merged patch set 2 01/22/26, 10:52