Review 13.4 Merged

92462[BUGFIX] Locale with Dependencies

Achim Fritz CR +2 V +2 Easy +1 −1 updated 01/23/26, 07:51

Commit message

Locale from SiteLanguage has no dependencies built
so e.g. for locale da_DK the dependency to da is missing
this leeds to no loading of da locallang files
only the PageRepository->readLLfile Method is affected
which is called from PageRepository->includeLanguageFileForInline
when including Language Files in TypoScript with
page.inlineLanguageLabelFiles

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Achim Fritz uploaded patch set 1 01/22/26, 15:36

  2. Achim Fritz updated the commit message in patch set 2 01/22/26, 15:44

  3. core-ci voted on patch set 1 V +1 01/22/26, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94055

  4. core-ci voted on patch set 2 V +1 01/22/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94058

  5. Benni Mack updated the commit message in patch set 3 V +1 01/22/26, 17:10

  6. core-ci voted on patch set 3 V +1 01/22/26, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94070

  7. Stefan Bürk commented on patch set 3 01/23/26, 00:20

    @benni@typo3.org @af@achimfritz.de Same issue as 92465: [BUGFIX] Locale with Dependencies | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92465 operating on another place. Which one is correct or do we need both ?
  8. Garvin Hicking commented on patch set 3 CR +1 V +1 01/23/26, 07:45

    Reply

    (this one here is the 13.4 backport already)
  9. Benni Mack voted on patch set 3 CR +2 V +2 01/23/26, 07:51

  10. Benni Mack merged patch set 4 01/23/26, 07:51