Review main Merged

92463[BUGFIX] Allow label file override in composer mode

Benni Mack CR +2 V +2 Easy +20 −14 updated 01/23/26, 08:27

Commit message

In composer mode, the extensions are all put into
vendor/. If you have a localized label file,
such as "EXT:my_site/Resources/Private/Language/de.locallang.xlf"
this wasn't found anymore in v14 due to the domain
resolving.

The change now checks for all registered package
paths which is much less volatile than the previous
package path resolving.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 01/22/26, 16:23

  2. core-ci voted on patch set 1 V -1 01/22/26, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94062

  3. Benni Mack uploaded patch set 2 V -1 01/22/26, 16:42

  4. core-ci voted on patch set 2 V +1 01/22/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94065

  5. Benni Mack updated the commit message in patch set 3 V +1 01/22/26, 17:03

  6. Benni Mack marked it ready for review 01/22/26, 17:03

  7. core-ci voted on patch set 3 V +1 01/22/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94067

  8. Jochen Roth voted on patch set 3 CR +1 V +1 01/22/26, 18:38

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 01/23/26, 07:59

    "works on my machine". I found out that `vendor/bin/typo3 language:domain:search --locale=de --search 'eindeutigem'` does not find the string in `de/filelist/Resources/Private/Language/de.locallang.xlf`. But that also happens without the patch, so something I'll look up on its own.
  10. Josua Vogel voted on patch set 3 CR +1 V +1 01/23/26, 08:24

  11. Benni Mack commented on patch set 3 CR +2 V +2 01/23/26, 08:27

    thank you!
  12. Benni Mack merged patch set 4 01/23/26, 08:27