Review main Merged

92464[TASK] Add example content for EXT:theme_camino

Benjamin Kott CR +2 V +2 Nightmare +5817 −2 updated 03/30/26, 07:32

Commit message

Adds initialisation data including pages, content elements, and images
that are automatically imported on first activation. This provides a
ready-to-use website out of the box, giving users a working starting
point with the Camino theme.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 3849

Show 1924 earlier messages
  1. Benjamin Kott uploaded patch set 1 01/22/26, 16:32

  2. core-ci voted on patch set 1 V +1 01/22/26, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94063

  3. Garvin Hicking commented on patch set 1 01/22/26, 18:42

    These 40MB of assets (not well compressible) is a dummy for now, right? I think the assets could be compressed (avif?) by a lot.
  4. Benjamin Kott commented on patch set 1 01/23/26, 07:00

    Reply

    i just dumped it here, so @markus@timtner.de can clean it up and work on it 🤣 added to the ticket that it should not stay that way.
  5. Benjamin Kott updated the commit message in patch set 2 V +1 01/23/26, 07:02

  6. core-ci voted on patch set 2 V +1 01/23/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94127

  7. Markus Timtner commented on patch set 2 01/23/26, 10:16

    Hi, import worked for me, will work and refine on that now!
  8. Lina Wolf commented on patch set 2 01/25/26, 13:01

    Looking forward to this change, will make the documentation much easier if we dont have to create example contents
  9. Garvin Hicking commented on patch set 2 01/25/26, 13:49

    Reply

    We need to watch out though; if v15 gets a new theme (and v16, ...) that would lead to very specific contents and different imports. We should not too tightly couple camino to the docs.
  10. Markus Timtner commented on patch set 2 01/25/26, 13:51

    Reply

    I am working on creating some generic contents necessary for testing.
  11. Benni Mack commented on patch set 2 02/13/26, 12:47

    Reply

    Hey Markus - any progress on this topic?
  12. Markus Timtner commented on patch set 2 02/13/26, 13:34

    Reply

    Yes, I have the default elements here plus a setup to test search and login, but still have to bundle that and commit it here.
  13. Benjamin Kott uploaded patch set 3 V +1 02/25/26, 16:08

  14. Benjamin Kott commented on patch set 3 02/25/26, 16:09

    Reply

    Done

    Reply

    Example content is now updated and ready for initial shipment
  15. core-ci voted on patch set 3 V +1 02/25/26, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96838

  16. Benjamin Franzke commented on patch set 3 CR -1 02/26/26, 11:30

    File `3ae52e45d28eaf7b501201342e24397fa082324d` has ~460KiB, because it compresses badly, even with webp, while ohter files are around ~100KiB. Any chance to generate/use a header image that is smaller and compresses better (uses less noise)?

    data.xml:1742

    We should omit default values (and field values that are not relevant for the respective subschema)
  17. Benni Mack uploaded patch set 4 CR -1 V +1 03/06/26, 21:15

  18. Benni Mack commented on patch set 4 03/06/26, 21:18

    data.xml:1742 Reply

    I built a new export version with the current main. we've cut the file in half a) new setup (no additional fields) b) dealing with subschemes properly default values might have side-effects.
  19. core-ci voted on patch set 4 V +1 03/06/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97527

  20. Garvin Hicking commented on patch set 4 V -1 03/15/26, 17:42

    I tried this in a core monorepo setup. That setup had no entries in tables: `pages` `tt_content` `sys_file_reference` `tx_themecamino_list_item` `sys_file_storage` `sys_file` `sys_file_metadata` `fe_users` Note that I of course had two `be_users` entries (admin and _cli_). No site config existed. I made sure that theme_camino was not activated. I made sure no sys_registry values existed. Then I activated the extension. However, no data was imported into `pages`. After operation sys_registry contained: ``` 84 extensionDataImport theme_camino:ext_tables_static+adt.sql s:0:""; 85 extensionDataImport theme_camino:Initialisation/dataImported i:1; ``` The initialisation DID however create ONE record in `sys_file`: ``` INSERT INTO `sys_file` (`uid`, `pid`, `tstamp`, `last_indexed`, `identifier`, `identifier_hash`, `folder_hash`, `extension`, `name`, `sha1`, `creation_date`, `modification_date`, `storage`, `type`, `mime_type`, `size`, `missing`, `metadata`) VALUES (1, 0, 1773596327, 1773596327, '/camino/max-kukurudziak-mrNvSPGBDk0-unsplash.webp', '0b6c8c3fb4a5fef3161c679c5329efce71770dab', 'f4f34c530beaa7932a7f96c824072f063790283f', 'webp', 'max-kukurudziak-mrNvSPGBDk0-unsplash.webp', '3ae52e45d28eaf7b501201342e24397fa082324d', 1773595580, 1773595580, 1, 2, 'image/webp', 474132, 0, 0); ``` and also one in `sys_file_metadata`, one `sys_file_storage` entry. I have not worked much with `Initalisation/data.xml`. What am I testing wrong? Also: I agree the art assets currently are too large (1.8MB in sum). Converting them to AVIF drops it down to 800kb. However at least three files are very dense in small details as Benjamin noted. Maybe we could find alternate images that have less small textures and more "covered". We could also make sure that these assets have proper licenses and used assets are credited if needed (unsplash needs that usually?).
  21. Benni Mack uploaded patch set 5 V +1 03/22/26, 15:52

  22. core-ci voted on patch set 5 V +1 03/22/26, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98392

  23. Benni Mack commented on patch set 5 03/22/26, 16:47

    Reply

    I updated the import now, so it works. However we need some person with additional time to research a new image, also adding credits. Anyone up for it? In addition, the installer doesn't set up the new DB + site in the SetupService.php, so we can do this in this change or in a separate change. Ideas?
  24. Benni Mack marked it ready for review 03/22/26, 16:47

  1. Benjamin Kott uploaded patch set 6 V +1 03/24/26, 14:58

  2. core-ci voted on patch set 6 V +1 03/24/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98607

  3. Benjamin Kott rebased onto patch set 7 V +1 03/24/26, 23:11

  4. core-ci voted on patch set 7 V -1 03/24/26, 23:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98631

  5. Benjamin Kott uploaded patch set 8 V -1 03/25/26, 00:01

  6. core-ci voted on patch set 8 V -1 03/25/26, 00:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98633

  7. Benjamin Kott uploaded patch set 9 V -1 03/25/26, 00:19

  8. core-ci voted on patch set 9 V -1 03/25/26, 00:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98634

  9. Ravi Sachaniya voted on patch set 9 CR +1 V +1 03/25/26, 06:28

  10. Benjamin Kott rebased onto patch set 10 CR +1 V +1 03/25/26, 07:35

  11. Benjamin Kott commented on patch set 10 03/25/26, 07:37

    Reply

    Done

    Reply

    should work now with the chain applied - resolving for now
  12. core-ci voted on patch set 10 V +1 03/25/26, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98657

  13. Ravi Sachaniya voted on patch set 10 CR +1 V +1 03/26/26, 05:26

  14. Benjamin Franzke commented on patch set 10 03/26/26, 07:13

    data.xml:3112

    I (still) think we should introduce a "minimal" export flag that omits default values, similar to what we did in: > 93006: [WIP][TASK] Ignore default values in export | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93006 (Of course that is something that needs to be configurable, since regular exports are fine to include default values, in case default values change in future, but for camino default values should be omitted, since data-source and default values are shipped synchronously (in our repository), that means all default values we ship in this export are actually redundancies)
  15. Benni Mack commented on patch set 10 03/27/26, 20:40

    data.xml:3112 Reply

    this can be a separate option, but I think we can decouple this discussion from the current patch - and move this forward. I'd love to have the configuration stored in the XML as well.
  16. Benjamin Franzke commented on patch set 10 03/27/26, 21:35

    data.xml:3112 Reply

    Acknowledged
  17. Benjamin Franzke rebased onto patch set 11 CR +1 V +1 03/30/26, 07:09

  18. Benjamin Franzke commented on patch set 11 03/30/26, 07:09

    config.yaml:1

    Removed this file because it is also embedded in `typo3/sysext/theme_camino/Initialisation/data.xml`.
  19. Benjamin Franzke uploaded patch set 12 03/30/26, 07:10

  20. Benjamin Franzke voted on patch set 12 CR +1 V +1 03/30/26, 07:10

  21. Ravi Sachaniya voted on patch set 12 CR +1 V +1 03/30/26, 07:13

  22. core-ci voted on patch set 12 V +1 03/30/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99009

  23. Josua Vogel voted on patch set 12 CR +1 V +1 03/30/26, 07:26

  24. Benjamin Kott voted on patch set 12 CR +2 V +2 03/30/26, 07:32

  25. Benjamin Kott merged patch set 13 03/30/26, 07:32