Review main Merged

92465[BUGFIX] Locale with Dependencies

Benni Mack CR +2 V +2 Easy +2 −1 updated 01/23/26, 07:51

Commit message

Locale from SiteLanguage has no dependencies built
so e.g. for locale da_DK the dependency to da is missing
this leeds to no loading of da locallang files
only the PageRepository->readLLfile Method is affected
which is called from PageRepository->includeLanguageFileForInline
when including Language Files in TypoScript with
page.inlineLanguageLabelFiles

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 01/22/26, 17:09

  2. core-ci voted on patch set 1 V +1 01/22/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94069

  3. Jochen Roth voted on patch set 1 CR +1 V +1 01/22/26, 18:40

  4. Stefan Bürk commented on patch set 1 01/23/26, 00:21

    @benni@typo3.org @af@achimfritz.de Same issue as 92462: [BUGFIX] Locale with Dependencies | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92462 operating on another place. Which one is correct or do we need both ?
  5. Garvin Hicking commented on patch set 1 CR +1 V +1 01/23/26, 07:45

    Reply

    the other is the 13.4 backport, with structual changes because main refactored TSFE
  6. Benni Mack voted on patch set 1 CR +2 V +2 01/23/26, 07:51

  7. Benni Mack merged patch set 2 01/23/26, 07:51