Review main Merged

92467[TASK] Re-structure standard content preview renderer

Benni Mack CR +2 V +2 Normal +103 −53 updated 01/23/26, 21:00

Commit message

This fully utilizes record API and adds some preview
for bullets + html Ctype, as well as optimizations
for regular content output and menu rendering.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1

Issues 1

Files 2

Review log 1219

  1. Benni Mack uploaded patch set 1 01/22/26, 19:14

  2. core-ci voted on patch set 1 V -1 01/22/26, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94085

  3. Benni Mack rebased onto patch set 2 V -1 01/22/26, 19:59

  4. core-ci voted on patch set 2 V -1 01/22/26, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94094

  5. Benni Mack uploaded patch set 3 V -1 01/22/26, 20:10

  6. core-ci voted on patch set 3 V +1 01/22/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94097

  7. Simon Schaufelberger commented on patch set 3 01/22/26, 21:45

    StandardContentPreviewRenderer.php:113

    it would be easier to read when we return '' instead of a variable where you first need to check what's in there. I would also return the message down below directly. probably we can get rid of the out variable completely.
  8. Benni Mack commented on patch set 3 01/23/26, 08:50

    StandardContentPreviewRenderer.php:113 Reply

    Care to make the changes you suggest? I don't mind the code base, and I just separated this change from that one (https://review.typo3.org/c/Packages/TYPO3.CMS/+/92127) for separation of concern as a prepatch.
  9. Simon Schaufelberger uploaded patch set 4 V +1 01/23/26, 11:51

  10. Simon Schaufelberger commented on patch set 3 01/23/26, 11:51

    StandardContentPreviewRenderer.php:113 Reply

    Done
  11. core-ci voted on patch set 4 V -1 01/23/26, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94161

  12. core-ci voted on patch set 4 V +1 01/23/26, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94161

  13. Simon Schaufelberger uploaded patch set 5 V +1 01/23/26, 19:02

  14. core-ci voted on patch set 5 V +1 01/23/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94198

  15. Benni Mack commented on patch set 6 V +1 01/23/26, 20:45

    Published edit on patch set 5.
  16. Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/23/26, 20:47

  17. Georg Ringer voted on patch set 6 CR +2 V +2 01/23/26, 20:59

  18. Georg Ringer merged patch set 7 01/23/26, 21:00

  19. core-ci voted on patch set 6 V +1 01/23/26, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94210