Review main Merged

92473[BUGFIX] Consider xclassed domain model in extbase file upload

Torben Hansen CR +2 V +2 Normal +118 −1 updated 01/24/26, 16:42

Commit message

The Extbase fileupload feature does not take into account
that a domain model can be extended via xclass. Therefore,
the file upload annotation/attribute is not processed
and uploading files for properties of the extended domain
model will fail.

This change fixes the problem by resolving a possible
extended domain model in `FileHandlingService` for the
current processed attribute via
`GeneralUtility::getClassName()`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Simon Praetorius +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Simon Praetorius +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1316

  1. Torben Hansen uploaded patch set 1 01/23/26, 07:16

  2. Torben Hansen marked it work in progress 01/23/26, 07:16

  3. core-ci voted on patch set 1 V +1 01/23/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94131

  4. Torben Hansen uploaded patch set 2 V +1 01/23/26, 18:28

  5. core-ci voted on patch set 2 V +1 01/23/26, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94195

  6. Torben Hansen updated the commit message in patch set 3 V +1 01/24/26, 12:41

  7. core-ci voted on patch set 3 V +1 01/24/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94253

  8. Torben Hansen marked it ready for review 01/24/26, 13:05

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 01/24/26, 13:06

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/24/26, 13:19

  11. Oliver Klee voted on patch set 3 V +1 01/24/26, 15:23

  12. Oliver Klee voted on patch set 3 CR +1 01/24/26, 15:24

  13. Simon Praetorius voted on patch set 3 CR +1 V +1 01/24/26, 15:54

  14. Guido Schmechel voted on patch set 3 CR +1 V +1 01/24/26, 16:29

  15. Garvin Hicking voted on patch set 3 CR +2 V +2 01/24/26, 16:41

  16. Garvin Hicking merged patch set 4 01/24/26, 16:42