Review main Merged

92474[TASK] Use record in theme_camino

Matthias Vogel CR +2 V +2 Normal +68 −70 updated 01/23/26, 16:19

Commit message

We now use the record object wherever possible
instead of using data in template files.

The record object is already available
as lib.contentElement uses the dataProcessor record-transformation.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Simon Praetorius +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1318

  1. Matthias Vogel uploaded patch set 1 01/23/26, 07:19

  2. Matthias Vogel uploaded patch set 2 01/23/26, 07:21

  3. Matthias Vogel updated the commit message in patch set 3 01/23/26, 07:26

  4. core-ci voted on patch set 1 V +1 01/23/26, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94132

  5. core-ci voted on patch set 2 V +1 01/23/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94133

  6. core-ci voted on patch set 3 V +1 01/23/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94135

  7. Simon Praetorius commented on patch set 3 CR -1 01/23/26, 10:57

    CaminoTextmediaTeaserGrid.fluid.html:12

    I'm not sure if this will throw exceptions somewhere. Is this a empty() or isset() check?

    Generic.fluid.html:12

    This should work: typoscriptObjectPath="{record.fullType}.20" data="{record.rawRecord}" table="{record.mainType}"

    Textpic.fluid.html:34

    `{record.recordType}`

    Anchor.fluid.html:6

    I think `{record.computedProperties.localizedUid}` should be possible here. If we don't retain both anchors (translated and non-translated), `{record.overlaidUid}` could be used, but this changes existing behavior.
  8. Oliver Hader commented on patch set 3 01/23/26, 11:05

    I was searching, why using `record` worked out of the box - maybe the origins should be mentioned in the commit message as well. * `data` stems from the default `FLUIDTEMPLATE` cObject * `record` stems from `lib.contentElement` and the `record-transformation` data processor
  9. Matthias Vogel uploaded patch set 4 CR -1 V +1 01/23/26, 11:48

  10. Matthias Vogel commented on patch set 4 01/23/26, 11:48

    Reply

    Done

    CaminoTextmediaTeaserGrid.fluid.html:12 Reply

    will first check via ->has() and not throw any exception, just returns null. See https://github.com/TYPO3/Fluid/blob/main/src/Core/Variables/StandardVariableProvider.php#L125-L127

    Generic.fluid.html:12 Reply

    Done

    Textpic.fluid.html:34 Reply

    Done

    Anchor.fluid.html:6 Reply

    Done
  11. core-ci voted on patch set 4 V -1 01/23/26, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94160

  12. Matthias Vogel rebased onto patch set 5 V -1 01/23/26, 12:05

  13. core-ci voted on patch set 5 V +1 01/23/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94165

  14. Simon Praetorius commented on patch set 5 CR +1 V +1 01/23/26, 13:16

    CaminoTextmediaTeaserGrid.fluid.html:12 Reply

    Ah, nice. Forgot about that.
  15. Nikita Hovratov voted on patch set 5 CR +1 01/23/26, 14:22

  16. Oliver Hader voted on patch set 5 CR +1 V +1 01/23/26, 15:08

  17. Oliver Hader voted on patch set 5 CR +2 V +2 01/23/26, 16:19

  18. Oliver Hader merged patch set 6 01/23/26, 16:19