92474[TASK] Use record in theme_camino
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Simon Praetorius +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oliver Hader +2
- Simon Praetorius +1
- core-ci +1 CI
Issues 1
Files 18
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoAuthor.fluid.html+4 −4
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoHero.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoHeroSmall.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoHeroTextOnly.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoLinklist.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTestimonial.fluid.html+4 −4
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTextmediaTeaser.fluid.html+7 −7
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTextmediaTeaserGrid.fluid.html3+11 −11
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTextteaser.fluid.html+9 −9
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/Generic.fluid.html2+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/Text.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/Textpic.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/ContentPreviews/Hero.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Layouts/Content/Default.fluid.html+5 −5
- typo3/sysext/theme_camino/Resources/Private/Templates/Layouts/Pages/Default.fluid.html+0 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Content/Hero.fluid.html+7 −7
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Content/Textpic.fluid.html2+12 −12
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Wrapper/Anchor.fluid.html2+1 −2
Review log 1318
-
Matthias Vogel uploaded patch set 1 01/23/26, 07:19
-
Matthias Vogel uploaded patch set 2 01/23/26, 07:21
-
Matthias Vogel updated the commit message in patch set 3 01/23/26, 07:26
-
core-ci voted on patch set 1 V +1 01/23/26, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94132
-
core-ci voted on patch set 2 V +1 01/23/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94133
-
core-ci voted on patch set 3 V +1 01/23/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94135
-
Simon Praetorius commented on patch set 3 CR -1 01/23/26, 10:57
Generic.fluid.html:12This should work: typoscriptObjectPath="{record.fullType}.20" data="{record.rawRecord}" table="{record.mainType}"Textpic.fluid.html:34`{record.recordType}`Anchor.fluid.html:6I think `{record.computedProperties.localizedUid}` should be possible here. If we don't retain both anchors (translated and non-translated), `{record.overlaidUid}` could be used, but this changes existing behavior. -
Oliver Hader commented on patch set 3 01/23/26, 11:05
I was searching, why using `record` worked out of the box - maybe the origins should be mentioned in the commit message as well. * `data` stems from the default `FLUIDTEMPLATE` cObject * `record` stems from `lib.contentElement` and the `record-transformation` data processor -
Matthias Vogel uploaded patch set 4
CR -1V +101/23/26, 11:48 -
Matthias Vogel commented on patch set 4 01/23/26, 11:48
Reply
DoneCaminoTextmediaTeaserGrid.fluid.html:12Replywill first check via ->has() and not throw any exception, just returns null. See https://github.com/TYPO3/Fluid/blob/main/src/Core/Variables/StandardVariableProvider.php#L125-L127Generic.fluid.html:12ReplyDoneTextpic.fluid.html:34ReplyDoneAnchor.fluid.html:6ReplyDone -
core-ci voted on patch set 4 V -1 01/23/26, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94160
-
Matthias Vogel rebased onto patch set 5
V -101/23/26, 12:05 -
core-ci voted on patch set 5 V +1 01/23/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94165
-
Simon Praetorius commented on patch set 5 CR +1 V +1 01/23/26, 13:16
CaminoTextmediaTeaserGrid.fluid.html:12ReplyAh, nice. Forgot about that. -
Nikita Hovratov voted on patch set 5 CR +1 01/23/26, 14:22
-
Oliver Hader voted on patch set 5 CR +1 V +1 01/23/26, 15:08
-
Oliver Hader voted on patch set 5 CR +2 V +2 01/23/26, 16:19
-
Oliver Hader merged patch set 6 01/23/26, 16:19
CaminoTextmediaTeaserGrid.fluid.html:12