92479[BUGFIX] Fix resolving localized strings in language:domain:search CLI
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Ayke Halder +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Ayke Halder +1
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/lowlevel/Classes/Command/TranslationDomainSearchCommand.php+6 −7
- typo3/sysext/lowlevel/Classes/Localization/LabelFinder.php+7 −2
- typo3/sysext/lowlevel/Tests/Functional/Localization/Fixtures/de.wizard.xlfnew+12 −0
- typo3/sysext/lowlevel/Tests/Functional/Localization/LabelFinderTest.phpnew+113 −0
Review log 1924
-
Garvin Hicking uploaded patch set 1 01/23/26, 11:09
-
core-ci voted on patch set 1 V +1 01/23/26, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94153
-
Garvin Hicking uploaded patch set 2
V +101/23/26, 14:10 -
core-ci voted on patch set 2 V +1 01/23/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94175
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/23/26, 14:20
-
Josua Vogel voted on patch set 2 CR +1 V +1 01/23/26, 15:09
-
Benni Mack voted on patch set 2 CR +2 V +2 01/23/26, 15:29
-
Garvin Hicking commented on patch set 2 CR -1 01/23/26, 15:31
missing my test, hang on -
Garvin Hicking uploaded patch set 3
CR +1V +101/23/26, 15:34 -
core-ci voted on patch set 3 V -1 01/23/26, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94183
-
Garvin Hicking uploaded patch set 4
V -101/23/26, 15:50 -
core-ci voted on patch set 4 V +1 01/23/26, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94186
-
Benni Mack voted on patch set 4 CR +1 V +1 01/23/26, 16:37
-
Ayke Halder commented on patch set 4 01/23/26, 16:50
It finds the "de" translation now! But it says "Label Content (en)" instead of "… (de)", shouldn't it? Command: `ddev exec bin/typo3 language:domain:search -e core --locale=de --search=baum` ``` Labels in extension: core ========================= core.core file EXT:core/Resources/Private/Language/locallang_core.xlf ===================================================================== +-------------------------------------+-----------------------------------------------+ | Label Reference | Label Content (en) | +-------------------------------------+-----------------------------------------------+ | cm.tempMountPoint | Als Startpunkt für den Seitenbaum festlegen | | labels.openPageTreeOptionsMenu | Seitenbaum-Options-Menü öffnen | | labels.temporaryPageTreeEntryPoints | Temporäre Seitenbaum-Einstiegspunkte aufheben | +-------------------------------------+-----------------------------------------------+ core.tca file EXT:core/Resources/Private/Language/locallang_tca.xlf =================================================================== +-----------------------------------------+------------------------------------+ | Label Reference | Label Content (en) | +-----------------------------------------+------------------------------------+ | be_users.options_page_tree_entry_points | Seitenbaum-Einstiegspunkte | | page_tree_entry_points | Seitenbaum-Einstiegspunkte | | php_tree_stop | Verberge Unterseiten im Seitenbaum | +-----------------------------------------+------------------------------------+ core.db.pages file EXT:core/Resources/Private/Language/db/pages.xlf =================================================================== +-----------------+------------------------------------+ | Label Reference | Label Content (en) | +-----------------+------------------------------------+ | php_tree_stop | Verberge Unterseiten im Seitenbaum | +-----------------+------------------------------------+ [OK] Found 3 label references. . ``` -
Simon Schaufelberger voted on patch set 4 CR +1 V +1 01/23/26, 16:52
-
Simon Schaufelberger voted on patch set 4 CR 0 V 0 01/23/26, 17:05
-
Garvin Hicking uploaded patch set 5
CR +1V +101/23/26, 17:39 -
Garvin Hicking commented on patch set 5 01/23/26, 17:40
Reply
good catch, thank you - updated to utilize the locale there. -
core-ci voted on patch set 5 V +1 01/23/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94193
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/23/26, 18:39
-
Ayke Halder voted on patch set 5 CR +1 V +1 01/23/26, 19:17
-
Benni Mack voted on patch set 5 CR +1 V +1 01/23/26, 19:26
-
Garvin Hicking commented on patch set 5 CR +2 V +2 01/23/26, 19:27
Thanks for iterating 😎 -
Garvin Hicking merged patch set 6 01/23/26, 19:28