Review main Merged

92481[BUGFIX] Correctly exclude URL parameters in canonical URL generation

Benni Mack CR +2 V +2 Normal +146 −5 updated 01/23/26, 21:10

Commit message

When URL parameters have the same value as the page ID,
they are now properly excluded from canonical URLs.
Previously, the comparison only checked parameter values
instead of key-value pairs, causing system parameters
like "type" to remain in the canonical URL when their
value matched the page ID.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Benni Mack uploaded patch set 1 01/23/26, 12:25

  2. core-ci voted on patch set 1 V +1 01/23/26, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94168

  3. Benni Mack marked it ready for review 01/23/26, 16:37

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 01/23/26, 20:53

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/23/26, 21:07

  6. Benni Mack commented on patch set 1 CR +2 V +2 01/23/26, 21:09

    thanks!
  7. Benni Mack merged patch set 2 01/23/26, 21:10